[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#880884: marked as done (qtav: Adapt to libva 2)



Hello Sebastian,

On Sunday, November 12, 2017 7:21:30 PM CST Sebastian Ramacher wrote:

> >    [ Pino Toscano ]
> >    * Remove manual library and va-driver dependencies. (Closes: #880884)
> 
> I am afraid that this change is not enough. qtav still needs to be ported to
> the new libva.  Currently it links libva2, 

Concretely, what needs to be "ported"?  The sources build against libva2 as 
you say.  Aside from dlopen issues, below, what needs to change?

> but dlopens libva.so.1,
> libva-x11.so.1, and maybe others. 

How did you determine this?   I looked for dlopen in the code and found 
nothing.  Grepping for "libva" came up only with this code setting a 
"detail_display" property. 

VideoDecoderVAAPI::VideoDecoderVAAPI()
    : VideoDecoderFFmpegHW(*new VideoDecoderVAAPIPrivate())
{
    setDisplayPriority(QStringList() << QStringLiteral("X11") <<  
QStringLiteral("DRM") << QStringLiteral("GLX"));
    // dynamic properties about static property details. used by UI
    // format: detail_property
    setProperty("detail_surfaces", tr("Decoding surfaces") + QStringLiteral(" 
") + tr("0: auto"));
    setProperty("detail_derive", tr("Maybe faster"));
    setProperty("detail_display", QString("%1\n%2\n%3")
                .arg("X11: libva-x11.so is required")
                .arg("GLX: libva-glx.so is required")
                .arg("DRM: Support 0-copy only with EGL. May work without X11. 
libva-drm.so is required")
                );
}

I have no clue how this property is used, but it clearly does not specify the 
SO VERSION of any library.  So are we sure the problem lies within qtav?  Is 
it possibly a manifestation of #881521?

Thanks,
-Steve

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: