[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#881055: qtwebkit-opensource-src: FTBFS on x32: seems to use amd64-specific MacroAssembler code



Hi Thorsten!

On Wed, Nov 08, 2017 at 04:55:57PM +0100, Thorsten Glaser wrote:
> On Tue, 7 Nov 2017, Thorsten Glaser wrote:
>
> > I think that, as usual, the JIT is not ported to x32 yet
> > and therefore must be disabled on x32. (Untested assumption.)
>
> I’m getting closer with the attached patch, which does disable
> the JIT by fixing an assumption about amd64 as CPU architecture
> (the CPU architecture of the Debian architecture x32 is *also*
> amd64, but the ABI differs, like with ARM EABI vs. the old one
> or MIPS o32, n32, n64).

Thanks! I have already applied a similar fix in Git.

> However, the build still fails:
>
> ../Source/WTF/wtf/Assertions.h:338:35: error: static assertion failed: JSObject_inline_storage_has_correct_alignment
>  #define COMPILE_ASSERT(exp, name) static_assert((exp), #name)
>                                    ^
> ../Source/JavaScriptCore/runtime/JSObject.h:1496:1: note: in expansion of macro 'COMPILE_ASSERT'
>  COMPILE_ASSERT(!(sizeof(JSObject) % sizeof(WriteBarrierBase<Unknown>)), JSObject_inline_storage_has_correct_alignment);
>  ^~~~~~~~~~~~~~

I will cherry-pick https://github.com/WebKit/webkit/commit/0858ee607f376ae8
in the next upload, it should fix the remaining issue.

If you have time then please test it.

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature


Reply to: