[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#836299: signond: please use dbus-run-session to run tests



Source: signond
Version: 8.57+20150423-3
Severity: normal
Tags: upstream
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-x11 for tests under at least
some configurations.

It should be possible to replace dbus-x11 as follows:

* Upstream: in tests/run-with-signond.sh, instead of invoking dbus-launch
  in the fallback code path where there is no dbus-test-runner and
  killing the dbus-daemon afterwards, use

  dbus-run-session --config-file="${DBUS_CONFIG}" -- ${CLIENT_WRAPPER} "$@"

  (dbus-run-session behaves a bit like a simplfied dbus-test-runner)

* Debian-specific: replace
  "xvfb-run -a dbus-launch --exit-with-session dh_auto_test"
  with "xvfb-run -a dbus-run-session -- dh_auto_test"

* Debian-specific: replace Build-Depends on dbus-x11 with dbus (>= 1.8)

If D-Bus is the only reason you are using xvfb, you can remove that too,
and just use "dbus-run-session -- dh_auto_test".

Thanks,
    S


Reply to: