[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#821802: lokalize: FTBFS with (upcoming) hunspell 1.4



Package: lokalize
Version: 4:15.08.3-1
Severity: important
Tags: patch

Dear Maintainer,

lokalize FTBFSes with hunspell 1.4.0 (currently in NEW). It doesn't find
hunspell because the list in cmake/FindHUNSPELL.cmake doesn't know
hunspell-1.4:

[...]
-- Could NOT find HUNSPELL (missing:  HUNSPELL_LIBRARIES)   
CMake Error at /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:148 (message):  
  Could NOT find HUNSPELL (missing: HUNSPELL_LIBRARIES)
Call Stack (most recent call first):
  /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)  
  cmake/FindHUNSPELL.cmake:22 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)  
  src/CMakeLists.txt:4 (find_package)  
[...]

Trivial fix:

diff -Nru lokalize-15.08.3/debian/patches/hunspell-1.4.diff lokalize-15.08.3/debian/patches/hunspell-1.4.diff
--- lokalize-15.08.3/debian/patches/hunspell-1.4.diff   1970-01-01 00:00:00.000000000 +0000
+++ lokalize-15.08.3/debian/patches/hunspell-1.4.diff   2016-04-19 11:51:52.000000000 +0000
@@ -0,0 +1,11 @@
+--- lokalize-15.08.3.orig/cmake/FindHUNSPELL.cmake
++++ lokalize-15.08.3/cmake/FindHUNSPELL.cmake
+@@ -14,7 +14,7 @@ ENDIF (HUNSPELL_INCLUDE_DIR AND HUNSPELL
+ 
+ FIND_PATH(HUNSPELL_INCLUDE_DIR hunspell/hunspell.hxx )
+ 
+-FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-1.3 hunspell-1.2)
++FIND_LIBRARY(HUNSPELL_LIBRARIES NAMES hunspell-1.4 hunspell-1.3 hunspell-1.2)
+ 
+ # handle the QUIETLY and REQUIRED arguments and set HUNSPELL_FOUND to TRUE if 
+ # all listed variables are TRUE
diff -Nru lokalize-15.08.3/debian/patches/series lokalize-15.08.3/debian/patches/series
--- lokalize-15.08.3/debian/patches/series      1970-01-01 00:00:00.000000000 +0000
+++ lokalize-15.08.3/debian/patches/series      2016-04-19 11:51:46.000000000 +0000
@@ -0,0 +1 @@
+hunspell-1.4.diff

No idea what FIND_LIBRARY does, but can't it be made to use pkg-config which
would get rid of this issue for the future?

Would be nice to get it patced soon so the actual transition then can get
done more easily (bin-NMu instead of source upload)

Regards,

Rene

-- System Information:
Debian Release: 8.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: armhf (armv7l)

Kernel: Linux 3.18.0-trunk-rpi2 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)


Reply to: