[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Needed suggestions for creating a QT5 patched libraries package



Il 18/03/2016 14:31, Lisandro Damián Nicanor Pérez Meyer ha scritto:
On Friday 18 March 2016 11:50:45 Sandro Knauß wrote:
Hey Giovanni,

cool that you want to package telegram desktop.

However, Telegram Desktop requires a patched version of QT5; this is not
a major issue, I've already created such a package, based on the latest
Debian/Ubuntu sources and build nicely.

Well a patched QT5 is a big issue. Because in debian we don't want to ship
to versions of QT5. So if it is comiling is not the interessing point. The
main question is, why they need this patch and if the patch is going to be
included upstream. If it is approved from qt to be entered into mainline it
is possible to include the patch also to older versions of QT5 packages.
And for me the patch looks quite big:
https://github.com/telegramdesktop/tdesktop/blob/master/Telegram/
_qtbase_5_5_1_patch.diff

I have just looked over the patch. Those guys are doing it wrong: if you need
that functionality you should push it upstream, not patch it like that.

I'm afraid that as long as your upstream does that kind of weird things it
will not be possible to have their app in Debian.


I am well aware of that... In fact, I'll try to work on this in a personal PPA on Launchpad.
I'll also try to open an issue in the official bugtracker.
I hope they will change their approach and this gets in Debian officially in the future...!

So, from your suggestions, I just have to make this installation work alongside the official one? So, just installing in "different-from-usual" folders (to avoid conflicts) and tweak the packages dependencies?

As my problem is that I've already some packaged stuff:
https://launchpad.net/~itachi-san/+archive/ubuntu/telegramdesktop/+packages
You can see the "qtbase-opensource-src-patched" package which is the patched version of QT5...
But, from what you can spot from the buildlog here (i386):
https://launchpadlibrarian.net/243657253/buildlog_ubuntu-precise-i386.qtbase-opensource-src-patched_5.5.1+dfsg-2ubuntu1_BUILDING.txt.gz
and here (amd64):
https://launchpadlibrarian.net/243647276/buildlog_ubuntu-precise-amd64.qtbase-opensource-src-patched_5.5.1+dfsg-2ubuntu1_BUILDING.txt.gz
when the builder sets the dependencies, it points to the official QT ones.
I'd like some tips here.
My greedy approach would be to use sed and rename every "libqt5*" and "qtbase5*" package to respectively "libqt5p*" and "qtbase5p*", as I renamed the packages in my build attempt.

--
Giovanni Santini
My blog: http://giovannisantini.tk
My code: https://github.com/ItachiSan
My code, again: https://gitlab.com/u/ItachiSan
My Twitter: https://twitter.com/santini__gio
My Facebook: https://www.facebook.com/giovanni.santini
My Google+: https://plus.google.com/+GiovanniSantini/
My GPG: 2FADEBF5


Reply to: