[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

qtwebengine-opensource-src_5.7.1~20161021+dfsg-1_amd64.changes REJECTED



The debian/copyright looks pretty good.  I can tell a lot of effort went into
this package and it's a beast.  Unfortunately, I am going to have to reject it
due to sourceless javascript:

N: Not used
O: qtwebengine-opensource-src source: source-is-missing examples/webenginewidgets/contentmanipulation/jquery.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing examples/webenginewidgets/markdowneditor/resources/marked.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/analytics/google-analytics-bundle.js line length is 525 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/chaijs/chai.js line length is 844 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/v8/benchmarks/regexp.js line length is 2305 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/blanketjs/src/blanket.js line length is 4238 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/pyelftools/examples/sample_exe64.elf
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/web-animations-js/sources/web-animations-next-lite.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/web-animations-js/sources/web-animations-next.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/web-animations-js/sources/web-animations.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/dom_distiller_js/dist/js/domdistiller.js line length is 564 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/dom_distiller_js/dist/js/domdistiller_wrapped.js line length is 564 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/pycoverage/coverage/htmlfiles/jquery.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/pycoverage/coverage/htmlfiles/jquery.tablesorter.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/ui/accessibility/extensions/highcontrast/highcontrast.js line length is 3045 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/ui/webui/resources/js/jstemplate_compiled.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Source/devtools/front_end/acorn/acorn.js line length is 845 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Source/devtools/front_end/cm_modes/clojure.js line length is 536 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Source/devtools/front_end/cm_modes/php.js line length is 7403 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Source/devtools/front_end/cm_modes/stylus.js line length is 860 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Source/devtools/front_end/diff/diff_match_patch.js line length is 536 characters (>512)
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/skia/platform_tools/android/bin/linux/perfhost
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/coverage/htmlfiles/jquery-1.4.3.min.js
N: Not used
O: qtwebengine-opensource-src source: source-is-missing src/3rdparty/chromium/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/coverage/htmlfiles/jquery.tablesorter.min.js

I didn't check all these, but "not used" is not 100% correct.  The sourceless
javascript in the examples directory is shipped, but it doesn't matter.  The
source has to be in the source package to make the source package DFSG free.

In some cases, it seems these might be the preferred form of modification.  I
found:

https://github.com/GoogleChrome/chrome-platform-analytics/blob/master/google-analytics-bundle.js

If these are truly not used, just remove them from the tarball and re-upload.

Scott K



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.


Reply to: