Bug#841232: marble: Does not follow symlinks

[Marcos Dione <mdione@grulic.org.ar>]

Package: marble
Version: 4:16.04.1-3
Severity: wishlist

Dear Maintainer,

    marble has for ages disabled symlinks traversal in a great part of
the local cache code. I know for certain that developers have decided to
do so to avoid user reports related to dangling symlinks (sorry, I can't
find a reference now). This bug report is to see if the Debian
maintainers agree this is wrong. Attached you'll find a patch that
removes all the references to QDir::NoSymLinks from the code. I tested it
and it works fine now. I will keep having this patch around, but I hope
you find it useful too, so everyone else can profit from it, and I don't
have to recompile marble from time to time :)

    Cheers,

	-- Marcos.


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (700, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.7.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages marble depends on:
ii  libc6                   2.24-3
ii  libgcc1                 1:6.2.0-6
ii  libkf5configcore5       5.26.0-1
ii  libkf5configgui5        5.26.0-1
ii  libkf5configwidgets5    5.26.0-1
ii  libkf5coreaddons5       5.26.0-3
ii  libkf5i18n5             5.26.0-1
ii  libkf5kiowidgets5       5.26.0-1
ii  libkf5newstuff5         5.26.0-1
ii  libkf5parts5            5.26.0-1
ii  libkf5runner5           5.26.0-1
ii  libkf5widgetsaddons5    5.26.0-1
ii  libkf5xmlgui5           5.26.0-1
ii  libmarblewidget-qt5-24  4:16.04.1-3
ii  libqt5core5a            5.6.1+dfsg-3+b1
ii  libqt5dbus5             5.6.1+dfsg-3+b1
ii  libqt5gui5              5.6.1+dfsg-3+b1
ii  libqt5network5          5.6.1+dfsg-3+b1
ii  libqt5printsupport5     5.6.1+dfsg-3+b1
ii  libqt5widgets5          5.6.1+dfsg-3+b1
ii  libqt5xml5              5.6.1+dfsg-3+b1
ii  libstdc++6              6.2.0-6
ii  marble-data             4:16.04.1-3
ii  marble-plugins          4:16.04.1-3

marble recommends no packages.

Versions of packages marble suggests:
pn  gosmore               <none>
pn  monav-routing-daemon  <none>
pn  routino               <none>

-- no debconf information

-- 
(Not so) Random fortune:
Terrorism isn't a crime against people or property. It's a crime against
our minds, using the death of innocents and destruction of property to
make us fearful.
	    -- Bruce Schneier