Bug#836108: libaccounts-qt: please use dbus-run-session to run tests

[Simon McVittie <smcv@debian.org>]

Source: libaccounts-qt
Version: 1.13+20150813-1
Severity: normal
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-x11 for tests, explicitly launching
dbus-launch. It also seems to be missing the necessary build-dependency
on dbus-x11 - presumably that gets pulled in by something else,
or the "cd -" masks the error.

It should be possible to replace dbus-x11 as follows:

* add a build-dependency on dbus (>= 1.8)
* replace "xvfb-run -a dbus-launch --exit-with-session make check" with
  "xvfb-run -a dbus-run-session -- make check"

If D-Bus is the only reason you are using xvfb, you can remove that too,
and just use "dbus-run-session -- make check".

While you're editing the override_dh_auto_test stanza, it's probably also
a good idea to use "&&" instead of ";" so that test failures aren't
ignored, and remove the "cd -" bashism. (Each line of a Makefile recipe
is run in its own shell invocation, so cd'ing to a directory does not
affect subsequent lines unless you use "\" for line joining.)

Thanks,
    S