Bug#835053: kxmlgui: please make the build reproducible

[Pino Toscano <pino@debian.org>]

tag 835053 - patch
thanks

Hi,

In data domenica 21 agosto 2016 18:39:27 CEST, Chris Lamb ha scritto:
> Whilst working on the Reproducible Builds effort [0], I noticed
> that kxmlgui could not be built reproducibly.
> [...]
>
> kxmlgui.diff.txt
> --- a/debian/patches/reproducible-build.patch   1970-01-01 01:00:00.000000000 +0100
> --- b/debian/patches/reproducible-build.patch   2016-08-21 18:19:22.645111083 +0100
> @@ -0,0 +1,13 @@
> +Description: Make the build reproducible
> +Author: Chris Lamb <lamby@debian.org>
> +Last-Update: 2016-08-21
> +
> +--- kxmlgui-5.25.0.orig/src/config-xmlgui.h.cmake
> ++++ kxmlgui-5.25.0/src/config-xmlgui.h.cmake
> +@@ -1,5 +1,5 @@
> + #define XMLGUI_DISTRIBUTION_TEXT "${XMLGUI_DISTRIBUTION_TEXT}"
> +-#define XMLGUI_COMPILING_OS "${CMAKE_SYSTEM}"
> ++#define XMLGUI_COMPILING_OS "Generic"
> + #define XMLGUI_COMPILER_VERSION "${XMLGUI_COMPILER_VERSION}"

While I do appreciate the efforts in reproducible builds, this patch is
a no-go: the information here is used when reporting bugs, starting
from the "Help -> Report a Bug" menu of KDE/Frameworks applications.
The value is (at least was until some time ago) added in bug reports in
bugzilla, and that helps to know more about the environment in which
a bug happens.

Because of this, I'm removing the "patch" tag, and I'd suggest you to
bring this issue upstream directly (one between the mailing lists
kde-frameworks-devel@kde.org, kde-core-devel@kde.org or
kde-devel@kde.org) so this can be eventually discussed there.
Applying this patch in Debian locally would imply less information
regarding bugs coming from Debian (and possibly derivatives).

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.