[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825769: marked as done (Please add support for MATE desktop)

Your message dated Sun, 29 May 2016 22:32:24 +0000
with message-id <E1b79Fw-0005NG-Ha@franck.debian.org>
and subject line Bug#825769: fixed in qt4-x11 4:4.8.7+dfsg-8
has caused the Debian Bug report #825769,
regarding Please add support for MATE desktop
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
825769: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=825769
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qt4-x11
Version: 4:4.8.7+dfsg-7
Severity: wishlist
Tags: upstream patch

Hi,

Qt4 applications are smart enough to detect when they're run under GNOME
or XFCE, and use the GTK+ theme unless configured otherwise, thanks to a
bunch of tests that determine which desktop the application is running on.

Unfortunately, these tests don't include the MATE desktop; Qt5 does
include such a test, but a lot of applications still use Qt4 (for
example, on my system, I have avidemux, bitcoin-qt, clementine, and
skype which depend on Qt4 libs).

To determine if GNOME 2 is running, Qt4 checks for the presence of an
environment variable named GNOME_DESKTOP_SESSION_ID (which is said to be
deprecated, but Qt4 acknowledges this fact in its comments and still
uses it nevertheless). Since MATE is a fork of GNOME 2, it sets an
equivalent variable named MATE_DESKTOP_SESSION_ID, so I wrote a small
patch that simply duplicates the test with the new variable name.

I'm sure it could be made more elegant and check for both variables
names within the same test, but since I'm no C coder, I didn't want to
mess with the code so I chose the safe path. If you can rework the patch
in this way, this would be even better; the basic idea is to check for
MATE_DESKTOP_SESSION_ID (like the GNOME 2 test does) and if found,
pretend we're under GNOME (like the XFCE test does).

Anyway, here's the patch. I compiled Qt4 packages with it for my
personal use and they work as expected: Qt4 applications now use the
GTK+ theme natively when run under MATE, without any specific user
configuration (I removed ~/.config/Trolltech.conf to test that), whereas
with the unpatched version, it used to fall back on the "Default" (in
qt4-qtconfig) theme (the one which looks like Windows 9x).

Regards,

-- 
Raphaël Halimi

Description: Add support for MATE desktop
 This patch checks for an environment variable set by MATE desktop, in order to
 make Qt4 applications natively use the GTK+ style when run on this desktop
Author: Raphaël Halimi <raphael.halimi@gmail.com>
Origin: other
Last-Update: 2016-05-29
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/src/gui/kernel/qapplication_x11.cpp
+++ b/src/gui/kernel/qapplication_x11.cpp
@@ -2361,6 +2361,12 @@
                 break;
             }
 
+            // Check the equivalent environment variable set by MATE
+            if (!qgetenv("MATE_DESKTOP_SESSION_ID").isEmpty()) {
+                X11->desktopEnvironment = DE_GNOME;
+                break;
+            }
+
             rc = XGetWindowProperty(X11->display, QX11Info::appRootWindow(), ATOM(_DT_SAVE_MODE),
                                     0, 2, False, XA_STRING, &type, &format, &length,
                                     &after, &data);

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: qt4-x11
Source-Version: 4:4.8.7+dfsg-8

We believe that the bug you reported is fixed in the latest version of
qt4-x11, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 825769@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org> (supplier of updated qt4-x11 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 29 May 2016 16:48:10 -0300
Source: qt4-x11
Binary: libqtcore4 qtcore4-l10n libqtgui4 libqt4-network libqt4-opengl libqt4-script libqt4-scripttools libqt4-sql libqt4-sql-ibase libqt4-sql-mysql libqt4-sql-odbc libqt4-sql-psql libqt4-sql-sqlite libqt4-sql-sqlite2 libqt4-sql-tds libqt4-svg libqt4-xml libqt4-xmlpatterns libqt4-dbus libqtdbus4 libqt4-qt3support libqt4-designer libqt4-help libqt4-test libqt4-phonon libqt4-declarative libqt4-declarative-folderlistmodel libqt4-declarative-gestures libqt4-declarative-particles libqt4-declarative-shaders libqt4-dev libqt4-dev-bin libqt4-opengl-dev libqt4-dbg libqt4-designer-dbg libqt4-qt3support-dbg libqt4-script-dbg libqt4-xmlpatterns-dbg qt4-bin-dbg qt4-demos-dbg qt4-designer qt4-dev-tools qt4-qmake qt4-qtconfig qt4-demos qt4-qmlviewer qt4-linguist-tools qdbus qt4-doc qt4-doc-html qt4-default
Architecture: source
Version: 4:4.8.7+dfsg-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org>
Description:
 libqt4-dbg - Qt 4 library debugging symbols
 libqt4-dbus - Qt 4 D-Bus module
 libqt4-declarative - Qt 4 Declarative module
 libqt4-declarative-folderlistmodel - Qt 4 folderlistmodel QML plugin
 libqt4-declarative-gestures - Qt 4 gestures QML plugin
 libqt4-declarative-particles - Qt 4 particles QML plugin
 libqt4-declarative-shaders - Qt 4 shaders QML plugin
 libqt4-designer - Qt 4 designer module
 libqt4-designer-dbg - Qt 4 designer library debugging symbols
 libqt4-dev - Qt 4 development files
 libqt4-dev-bin - Qt 4 development programs
 libqt4-help - Qt 4 help module
 libqt4-network - Qt 4 network module
 libqt4-opengl - Qt 4 OpenGL module
 libqt4-opengl-dev - Qt 4 OpenGL library development files
 libqt4-phonon - Qt 4 Phonon module
 libqt4-qt3support - Qt 3 compatibility library for Qt 4
 libqt4-qt3support-dbg - Qt 3 compatibility library for Qt 4 debugging symbols
 libqt4-script - Qt 4 script module
 libqt4-script-dbg - Qt 4 script library debugging symbols
 libqt4-scripttools - Qt 4 script tools module
 libqt4-sql - Qt 4 SQL module
 libqt4-sql-ibase - Qt 4 InterBase/FireBird database driver
 libqt4-sql-mysql - Qt 4 MySQL database driver
 libqt4-sql-odbc - Qt 4 ODBC database driver
 libqt4-sql-psql - Qt 4 PostgreSQL database driver
 libqt4-sql-sqlite - Qt 4 SQLite 3 database driver
 libqt4-sql-sqlite2 - Qt 4 SQLite 2 database driver
 libqt4-sql-tds - Qt 4 FreeTDS database driver
 libqt4-svg - Qt 4 SVG module
 libqt4-test - Qt 4 test module
 libqt4-xml - Qt 4 XML module
 libqt4-xmlpatterns - Qt 4 XML patterns module
 libqt4-xmlpatterns-dbg - Qt 4 XML patterns library debugging symbols
 libqtcore4 - Qt 4 core module
 libqtdbus4 - Qt 4 D-Bus module library
 libqtgui4  - Qt 4 GUI module
 qdbus      - Qt 4 D-Bus tool
 qt4-bin-dbg - Qt 4 binaries debugging symbols
 qt4-default - Qt 4 development defaults package
 qt4-demos  - Qt 4 examples and demos
 qt4-demos-dbg - Qt 4 examples and demos debugging symbols
 qt4-designer - graphical designer for Qt 4 applications
 qt4-dev-tools - Qt 4 development tools
 qt4-doc    - Qt 4 API documentation
 qt4-doc-html - Qt 4 API documentation (HTML format)
 qt4-linguist-tools - Qt 4 Linguist tools
 qt4-qmake  - Qt 4 qmake Makefile generator tool
 qt4-qmlviewer - Qt 4 QML viewer
 qt4-qtconfig - Qt 4 configuration tool
 qtcore4-l10n - Qt 4 core module translations
Closes: 773270 825769
Changes:
 qt4-x11 (4:4.8.7+dfsg-8) unstable; urgency=medium
 .
   [ Pino Toscano ]
   * Disable pch also on powerpcspe; thanks Roland Stigge. (Closes: #773270)
 .
   [ Lisandro Damián Nicanor Pérez Meyer ]
   * Apply Raphaël Halimi's patch to add MATE detection (Closes: #825769).
   * Update symbols files with buildds' logs.
Checksums-Sha1:
 dfc93d05bb627870d85521b739484860cfa9c525 5904 qt4-x11_4.8.7+dfsg-8.dsc
 6ded9a9ad70ceae8ee12da5d92158638538de567 321872 qt4-x11_4.8.7+dfsg-8.debian.tar.xz
Checksums-Sha256:
 e32c311a9768d1b7b630c7748f76d8390c1a5c9ad5e4ad1072db17c30f367416 5904 qt4-x11_4.8.7+dfsg-8.dsc
 4bae246a930810584615813b75d8360b2906ff79fa5cb7430d858b45963bec33 321872 qt4-x11_4.8.7+dfsg-8.debian.tar.xz
Files:
 5f0a85f0ac2a7619b3ac567633b31357 5904 libs optional qt4-x11_4.8.7+dfsg-8.dsc
 aeceb3368c3d3a26e0e0c93130567e32 321872 libs optional qt4-x11_4.8.7+dfsg-8.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXS0fxAAoJEKtkX0BihqfQSMoQALjCy0yiOeJzwgwGQ3nx6p1D
qJlfEpaAHEDa3oBCb0sGgCHTY0I7/e6AnED0w5BegWo8/hwurG9RfqbiO79GOrrA
+j+V1u3EeBATLvc40tg0wsuTwvuIgm5xu0i8yGgEXAfxqNetZb6JRS4YwTuXdslW
5XCdTxvyrebGpqu0JFjmLd0nlC88BzGkERm3F7985Rj1O5PurnhG38klhYLZIwXm
tiUPSqkS8CjU95Llch6RwflrSynVUy86f1oyYxYtuqHwr/Gh4yqyyuOUm0ys5tdR
wmT4I7CDgXIIhBlF+e8SCZPXK1IhfWACFyl103P+ObLZ7hUW+4WoNUPtREcoZuma
viNgNLVP4wRUFlK3wrsiFochFjwvWPx+54cR8jOWQEdzF3z1wUeORlqyT2q/+pX1
zTeqTCmqx5EZbF8Xswma0rL1UA/me9OKMIStcCL8tk6whze0xz0O4kTmf6tS9i+h
n7HpRdxHDP2YwywUF8R/GJymj1SWs0QO1C87lcCPLIGWSxA/3URVyxHxedt9MVyB
1PHtKnP0IVA/3yFrHj/bOpMGtIgcUQQMtXQ/fNJTMiC4xUI1E18D3l0mEuq8LSLk
+cr/vCYmLTRqf4icYwSHw4s3AwYGP1MQul9uK8FnFJnDEjHIxNSkizWQDUcs66vB
ZM6aBjn0staO70YYMENa
=6VsW
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: