On Friday 09 October 2015 23:58:14 Guillem Jover wrote: > Control: tag -1 patch > > On Thu, 2015-07-16 at 18:37:48 -0300, Lisandro Damián Nicanor Pérez Meyer wrote: > > But QML *requires* SSE2, so.. this won't be fixed :( > > I just upgraded two main workstations of mine with AMD Athlon MP and XP > CPUs, and they crashed with an abort, with drkonqi showing up with > backtraces but no actual visible error message. After a «startx startkde» > I discovered that the QML code knows it cannot run, prints an error and > aborts, and found this bug report and the discussions upstream. > > Almost everything that is needed is already there, it just needs some > code shuffling. Attached is a tested and working patch that keeps the > JIT requiring SSE2, uses that if the cpu supports it, and fallsback to > the interpreter otherwise. Hi Guillem! The patch really looks nice, thanks for it! But we really need to upstream this and in order to achieve this we need you to either push it trough Qt's gerrit instance and accept the CLA in the process (*please* read below) or license the patch under a BSD-like license. CLA: the CLA is available in [cla]. **Please** note that, as stated in the link, you still retain copyright over your contributions. [cla] <http://www.qt.io/contributionagreement/> BSD: in case you don't want to agree with the CLA you can still put the patch under a BSD-like license. In this case we are able to push the patch upstreams ourselves, but if corrections are needed we need to act as proxies between you and upstream's gerrit instance [cr], thus possibly adding noise to the system. So I invite you to at least review the CLA. If you agree with it you will need an account on [qt.io] and then submit the code to [cr]. Use the Gerrit introduction in [gi], and do not hesiate in pinging me if you need help with this. [cr] <https://codereview.qt-project.org/> [qt.io] <http://www.qt.io/developers/> [gi] <https://wiki.qt.io/Gerrit_Introduction> Finally the patch would need a longer description of it's intended purpose. Thanks in advance, Lisandro. -- Sobre Argentina: "sé que es uno de los países mas hospitalarios del mundo" Albert Einstein Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/
Attachment:
signature.asc
Description: This is a digitally signed message part.