[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#777530: qt4-x11: prevent 'warning: "_ABIO32" is not defined' on mips64el



Source: qt4-x11
Version: 4:4.8.6+git64-g5dc8b2b+dfsg-2
Severity: normal
Tags: patch

Hi,

When building kde-workspace on mips64el, I was getting a lot of warnings
like this:
> /usr/include/qt4/QtCore/qatomic_mips.h:106:18: warning: "_ABIO32" is not defined [-Wundef]
>  #if _MIPS_SIM == _ABIO32
>                   ^

I've attached a patch which fixes this by including the sgidefs.h header
before the use of the _ABIO32 macro, which defines the macro if it isn't
defined yet.

Thanks,
James

Description: include sgidefs.h in qatomic_mips.h
 On mips64el _ABIO32 is not defined so whenever this header is included it
 prints a warning about it not being defined. Including sgidefs.h fixes this
 warning because it defines _ABIO32 everywhere.
Author: James Cowgill <james410@cowgill.org.uk>
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/src/corelib/arch/qatomic_mips.h
+++ b/src/corelib/arch/qatomic_mips.h
@@ -103,6 +103,8 @@ Q_INLINE_TEMPLATE bool QBasicAtomicPoint
 
 #if defined(Q_CC_GNU) && !defined(Q_OS_IRIX)
 
+#include <sgidefs.h>
+
 #if _MIPS_SIM == _ABIO32
 #define SET_MIPS2 ".set mips2\n\t"
 #else

Reply to: