Bug#764893: PATCH for qtwebsockets-opensource-src FTBFS (hppa/ppc/all)

[Helge Deller <deller@gmx.de>]

Hi Dmitry,

On 25.01.2015 08:49, Dmitry Shachnev wrote:
> On Sat, 24 Jan 2015 21:43:11 +0100, Helge Deller wrote:
> > Attached patch fixes everything on the hppa architecture.
> > I'm sure that it will fix  powerpc and ppc64el architectures too.
>
> Thanks a lot for the patch, it does fix powerpc and ppc64el too.

Great!

> I am uploading it to Debian right now.
>
> Do you know why the issue was happening only on these architectures
> and only with qtbase 5.4 (not 5.3)?

I don't know for sure, but in Qt it's documented that you should
use the SIGNAL() and SLOT() handlers should be used to avoid issues
on various platforms (to be cross platform compatible).
So I think it's a mixture of various effect.
Overall it's a long time ago that I did Qt development.

> > If it's correct, maybe can push it upstream to https://bugreports.qt.io/browse/QTBUG-43804 ?
>
> Upstream Qt uses Gerrit [1][2] for code review, so please submit your
> patch that way if you can (you will also need to sign the CLA to be
> able to do that).

I would prefer if you could handle that.
I don't have such agreements signed...
 
Helge