Re: unblock (pre-approval): kde-workspace/4:4.11.13-2.1
On Thursday 02 April 2015 21:10:00 John Paul Adrian Glaubitz wrote:
> On 04/02/2015 04:26 PM, John Paul Adrian Glaubitz wrote:
> > Attaching revision 2 of my debdiff.
>
> While reviewing my own patch, I noticed a typo in the change I made
> in the debian/rules file (overriden_command -> overridden_command).
>
> I have fixed this now and made the changelog entry slightly more
> accurate. Attaching revision 3 of my patch.
I wouldn't mind a better systemd integration, but your patch seems half done.
You have lost the integration with the desktop-base package and the related
theming.
Do you even get a valid kdm configuration by this patch in a new setup?
the setup_config() function in the current init script is there for a reason.
/Sune
--
I didn’t stop pretending when I became an adult, it’s just that when I was a
kid I was pretending that I fit into the rules and structures of this world.
And now that I’m an adult, I pretend that those rules and structures exist.
- zefrank
Reply to: