[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#744173: pkg-kde-tools: add arm64 support to SymbolsHelper



On Sunday 13 April 2014 03:14:19 Wookey wrote:
> +++ Lisandro Damián Nicanor Pérez Meyer [2014-04-12 10:41 -0300]:
> > On Saturday 12 April 2014 10:07:35 Maximiliano Curia wrote:
> > > ¡Hola Wookey!
> > > 
> > > El 2014-04-11 a las 23:29 +0100, Wookey escribió:
> > > > I read here: https://lists.debian.org/debian-68k/2013/11/msg00012.html
> > > > that in QT5 qreal is a double on armhf, but on QT4 it's a float (and
> > > > it's float on both for armel). Can this helper know which it is doing
> > > > and DTRT? If not which should be the default?
> > 
> > There is simply no need for the helper to know the right substitution
> > because you should not have symbols from Qt4 and Qt5 in the same symbols
> > file.
> I don't understand this part. Yes, we are not mixing the QT versions,
> but won't the same pkg-kde-tools helper be used whichever library is
> in use so it need to hand outthe right answers depending which library
> is being linked. Or do I misunderstand how this this is used?

Yes, pkg-kde-tools helper will be used, but it will be put in action only:

- If the symbols for at least two archs differ, which should not happen with 
qreal being double everywhere in Qt5 (it will work for other stuff, but there 
are no changes for anything else but qreal)

- If there is a substitution in the symbols file, which should not happen for 
qreal with Qt5. Else it would be a bug.
 
> > The substitutions are rarely added by hand on symbols, they are simply
> > detected by the helper when two different archs' build logs differ, as
> > it's
> > the case for Qt4.
> > 
> > In Qt5 there will be no symbols mismatch between archs for qreal, so no
> > substitution will be added and no further action is needed.
> 
> I thought that armel and armhf were going to be different (from each
> other). Did that change so everything uses double? (even sh4?)

In Qt5 qreal == double on all archs.

-- 
Cuando tenga duda, utilice la solución mas simple.
  Principio de William Occam, también llamado
  "la navaja de Occam"

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: