Your message dated Sat, 23 Aug 2014 12:29:40 +0200 with message-id <53F86D14.60703@googlemail.com> and subject line pkg-config patch no longer necessary, better solution found has caused the Debian Bug report #758336, regarding ffmpegthumbs: Use pkg-config to determine FFmpeg linker flags to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 758336: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758336 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: ffmpegthumbs: Use pkg-config to determine FFmpeg linker flags
- From: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>
- Date: Sat, 16 Aug 2014 23:39:06 +0200
- Message-id: <[🔎] 53EFCF7A.3070705@googlemail.com>
Source: ffmpegthumbs Version: 4:4.13.3-1 Severity: wishlist Tags: patch Usertags: reintroducing-ffmpeg Dear maintainer, I am working on reintroducing FFmpeg to Debian [1-2]. In order to make FFmpeg co-installable with Libav, the libraries were renamed to lib*-ffmpeg. Thus using linker flags like '-lavcodec' doesn't work with the FFmpeg packages. To get the correct linking flags for both FFmpeg and Libav, one can (and should) use pkg-config. Attached patch achieves that for this package. Please apply it to facilitate building your package with FFmpeg in Debian. If you want to facilitate this even further, you can also add lib*-ffmpeg-dev alternatives to the Libav build-dependencies. While the FFmpeg package is still waiting in the NEW queue [3], it can already be built from the git repository [4]. Best regards, Andreas 1: https://lists.debian.org/debian-devel/2014/07/msg01010.html 2: https://bugs.debian.org/729203 3: https://ftp-master.debian.org/new/ffmpeg_7:2.3.1-1.html 4: https://anonscm.debian.org/cgit/collab-maint/ffmpeg.gitdiff --git a/debian/patches/pkg-config.patch b/debian/patches/pkg-config.patch new file mode 100644 index 0000000..2edde6f --- /dev/null +++ b/debian/patches/pkg-config.patch @@ -0,0 +1,18 @@ +Description: Use pkg-config to determine FFmpeg linker flags + +Author: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com> +Last-Update: <2014-05-18> + +--- ffmpegthumbs-4.12.2.orig/cmake/FindFFmpeg.cmake ++++ ffmpegthumbs-4.12.2/cmake/FindFFmpeg.cmake +@@ -74,7 +74,9 @@ macro(find_component _component _pkgconf + ffmpeg + ) + +- find_library(${_component}_LIBRARIES NAMES ${_library} ++ string(REPLACE "-l" "" ${_component}_name "${PC_${_component}_LIBRARIES}") ++ ++ find_library(${_component}_LIBRARIES NAMES ${${_component}_name} ${_library} + HINTS + ${PC_LIB${_component}_LIBDIR} + ${PC_LIB${_component}_LIBRARY_DIRS} diff --git a/debian/patches/series b/debian/patches/series new file mode 100644 index 0000000..9937964 --- /dev/null +++ b/debian/patches/series @@ -0,0 +1 @@ +pkg-config.patch
--- End Message ---
--- Begin Message ---
- To: 758326-done@bugs.debian.org, 758327-done@bugs.debian.org, 758328-done@bugs.debian.org, 758329-done@bugs.debian.org, 758330-done@bugs.debian.org, 758331-done@bugs.debian.org, 758332-done@bugs.debian.org, 758333-done@bugs.debian.org, 758334-done@bugs.debian.org, 758335-done@bugs.debian.org, 758336-done@bugs.debian.org, 758337-done@bugs.debian.org, 758338-done@bugs.debian.org, 758339-done@bugs.debian.org, 758340-done@bugs.debian.org, 758341-done@bugs.debian.org, 758342-done@bugs.debian.org, 758343-done@bugs.debian.org, 758344-done@bugs.debian.org, 758345-done@bugs.debian.org, 758346-done@bugs.debian.org, 758347-done@bugs.debian.org, 758348-done@bugs.debian.org, 758349-done@bugs.debian.org, 758350-done@bugs.debian.org, 758351-done@bugs.debian.org, 758352-done@bugs.debian.org, 758353-done@bugs.debian.org, 758354-done@bugs.debian.org, 758355-done@bugs.debian.org, 758356-done@bugs.debian.org, 758357-done@bugs.debian.org, 758358-done@bugs.debian.org, 758360-done@bugs.debian.org, 758361-done@bugs.debian.org, 758362-done@bugs.debian.org, 758363-done@bugs.debian.org, 758364-done@bugs.debian.org, 758366-done@bugs.debian.org, 758367-done@bugs.debian.org, 758368-done@bugs.debian.org, 758369-done@bugs.debian.org, 758370-done@bugs.debian.org, 758371-done@bugs.debian.org, 758372-done@bugs.debian.org, 758373-done@bugs.debian.org, 758374-done@bugs.debian.org, 758375-done@bugs.debian.org, 758376-done@bugs.debian.org
- Subject: pkg-config patch no longer necessary, better solution found
- From: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>
- Date: Sat, 23 Aug 2014 12:29:40 +0200
- Message-id: <53F86D14.60703@googlemail.com>
Dear maintainer,I have found a simpler way to make it possible to link your package against FFmpeg in Debian: The lib*-ffmpeg-dev packages now install symbolic links from the standard lib*.so library names to the suffixed ones. This makes it possible to use the normal linker flags, e.g. '-lavcodec', to link against the FFmpeg libraries with '-ffmpeg' suffix.Thus the pkg-config patch is no longer necessary.I wish I had found this solution sooner and am sorry for the noise I created in your inbox.Best regards, Andreas
--- End Message ---