[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: simon's patches



¡Hola Vangelis!

I've been away for sometime, and with more pending things than time to finish
them afterwards, so, sorry that I haven't followed up your mails.

> Subject: [PATCH 1/4] debian/changelog: Prepare next release in Debian.
>  debian/changelog | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> -simon (0.4.1-1~) UNRELEASED; urgency=medium
> +simon (0.4.1-1.1) UNRELEASED; urgency=medium

To prepare a test unreleased package is a good practice to use a version lower
than the one you intend to upload, the 1~ is lower than 1, while 1.1 is
greater than 1. Also ~ means that is a prerelease, while 1.1 means its an
nmu.

> Subject: [PATCH 2/4] debian/watch: Fix to comply on the new URL
>  debian/watch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> -ftp://ftp.kde.org/pub/kde/stable/simon/([\d\.]+)/src/simon-(.*)\.tar\.(?:xz|bz2)
> +http://download.kde.org/stable/simon/([\d\.]+)/src/simon-(.*)\.tar\.(?:xz|bz2)

Ok, I've just applied slightly different version.

> Subject: [PATCH 3/4] debian/control: Add myself to Uploaders

Removed the trailing comma and applied.

> Subject: [PATCH 4/4] debian/copyright: Adopt new copyright as provided by
>  licensecheck.
>
> -Files: *

As I mentioned before, we prefer a general Files: * that cover most of the
files.

> +License: GPL-2+

...
> +License: GPL-2+

...
>  License: GPL-2+

You have at least three blocks with the same license, merge them into one,
merging files an copyright holders, in fact, let be Files: *

> +Files: plugins/Commands/Keyboard/flowlayout.cpp
> +       plugins/Commands/Keyboard/flowlayout.h
> +       simonlib/simonsound/qsemaphore2.cpp
> +       simonlib/simonsound/qsemaphore2.h
> +Copyright: 2009, 2011, Nokia Corporation and/or its subsidiary(-ies)
> +License: GPL-3+

These files seems to be under three optional licenses the Qt Commercial licenses
or LGPL-2.1 or GPL-3 (also, note that there is no or later in the text so the
+ is invalid).

-- 
"Any sufficiently advanced technology is indistinguishable from magic."
-- Clarke's Third Law
Saludos /\/\ /\ >< `/

Attachment: signature.asc
Description: Digital signature


Reply to: