Bug#631671: Running a kommander script fails

[Jim Scadden <jims@silentasylum.co.uk>]

On Sunday 18 May 2014 at 10:13:57, ewe2 wrote:

> I tried to build this with the patch on the 4.12.3-2 Debian source and
> dh_install failed with:
> 
> dh_install
> cp: cannot stat ‘debian/tmp/usr/lib/libcommanderwidgets.so’: No such file
> or directory
> dh_install: cp -a debian/tmp/usr/lib/libcommanderwidgets.so
> debian/kommander//usr/lib/ returned exit code 1libcommanderwidgets.so
> /usr/share/pkg-kde-tools/qt-kde-team/2/dhmk.mk:97: recipe for target
> 'pre_install_dh_install' failed
> make[1]: *** [pre_install_dh_install] Error 2
> make[1]: Leaving directory '/pub/deb/kdewebdev-4.12.3'
> /usr/share/pkg-kde-tools/qt-kde-team/2/dhmk.mk:110: recipe for target
> 'debian/dhmk_install' failed
> make: *** [debian/dhmk_install] Error 2

Did you apply the patch manually? The error shows dh_install was looking for 
libcommanderwidgets.so but the patch added libkommanderwidgets.so (with a k) 
to debian/kommander.install , so perhaps this was a typo?

On Sun, May 18, 2014 at 6:15 PM, Maximiliano Curia <maxy@debian.org> wrote:
> Oh, it's a missing plugin. kde4 plugins should be installed in under the
> /usr/lib/kde4/ tree, and avoid poluting /usr/lib
> 
> > The debian package contains .so.4.2.0 and .so.4 but not .so
> 
> The .4 and .4.2.0 files could probably be not-installed.
> 
> > The attached patch resolves the problem by including
> > libkommanderwidgets.so back in to the package.
> 
> Could you update the patch to install the plugins in /usr/lib/kde4/ ?

You're correct. I have modified the CMakeList.txt files so that it is built as a 
plugin with only a .so and installed to /usr/lib/kde4/ . There was also a 
runtime warning that plugins should not have a 'lib' prefix so I have also fixed 
this.

I have attached a new patch for the upstream source and an updated patch for 
debian/not-installed and debian/kommander.install

I have built packages using the patches on wheezy & jessie and also used 
pbuilder to build against sid.

Please let me know if any further modifications are necessary. If everything is 
ok then I would be happy to submit the upstream patch to the KDE BTS.

Thanks

--

Jim Scadden

--- a/debian/kommander.install
+++ b/debian/kommander.install
@@ -1,6 +1,5 @@
 usr/bin/kommander
 usr/lib/libkommandercore.so.4
 usr/lib/libkommandercore.so.4.2.0
-usr/lib/libkommanderwidgets.so.4
-usr/lib/libkommanderwidgets.so.4.2.0
+usr/lib/kde4/kommanderwidgets.so
 usr/share/applnk/.hidden/kommander.desktop
--- a/debian/not-installed
+++ b/debian/not-installed
@@ -5,6 +5,5 @@
 ./usr/include/specials.h
 ./usr/lib/libklinkstatuscommon.so
 ./usr/lib/libkommandercore.so
-./usr/lib/libkommanderwidgets.so
 ./usr/share/dbus-1/interfaces/org.kde.kdewebdev.klinkstatus.SearchManager.xml
 ./usr/share/dbus-1/interfaces/org.kde.kfilereplace.xml

--- a/kommander/widgets/CMakeLists.txt
+++ b/kommander/widgets/CMakeLists.txt
@@ -13,7 +13,7 @@
 
 ########### next target ###############
 
-SET(kommanderwidgets_LIB_SRCS
+SET(kommanderwidgets_PART_SRCS
 aboutdialog.cpp
 fontdialog.cpp
 buttongroup.cpp
@@ -50,7 +50,7 @@
 wizard.cpp
 )
 
-KDE4_ADD_LIBRARY(kommanderwidgets SHARED ${kommanderwidgets_LIB_SRCS})
+kde4_add_plugin(kommanderwidgets ${kommanderwidgets_PART_SRCS})
 
 ########### next target ###############
 
@@ -98,9 +98,7 @@
  ${KDE4_KIO_LIBS} 
 )
 
-SET_TARGET_PROPERTIES(kommanderwidgets PROPERTIES VERSION 4.2.0 SOVERSION 4 )
-INSTALL(TARGETS kommanderwidgets ${INSTALL_TARGETS_DEFAULT_ARGS})
-
+install(TARGETS kommanderwidgets DESTINATION ${PLUGIN_INSTALL_DIR})
 
 ########### install files ###############
 
--- a/kommander/executor/CMakeLists.txt
+++ b/kommander/executor/CMakeLists.txt
@@ -24,7 +24,6 @@
 TARGET_LINK_LIBRARIES(
   kommander
   kommandercore
-  kommanderwidgets
   ${KDE4_KDEUI_LIBS}
 )
 
--- a/kommander/lib/kommanderfactory.cpp
+++ b/kommander/lib/kommanderfactory.cpp
@@ -410,7 +410,7 @@
     KConfig config ( "kommanderrc" );
     KConfigGroup cfg ( &config, "plugins" );
     QStringList plugins;
-    plugins << "libkommanderwidgets";
+    plugins << "kommanderwidgets";
     plugins += cfg.readEntry ( "plugins", QStringList() );
     kDebug() << "Plugins: " << plugins;
     QStringList::Iterator it;