[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#741190: qt4-x11: Improve atomic support on parisc



OK, here's what upstream replied wrt the patch:

  Sorry, there's no way we can accept this patch. It is totally binary-
  incompatible for PA-RISC since it changes the size of QAtomicInt.
  Debian will need to keep the patch and ensure that everything is built with 
  the patch applied (or without it).

  What's more, I m not sure that you can set the IS_WAIT_FREE macros, since
  they are probably not wait-free. Just because you removed the explicit lock
  doesn't mean GCC won't use one behind your back in the __sync functions. I
  know it does that for ARM for types whose size are not 4 bytes. And knowing
  PA-RISC doesn't have wait-free atomic instructions, I doubt GCC can do it
  wait free either.

I will not have any problem to keep this delta **if and only if** you can 
prove is safe to set IS_WAIT_FREE macros.

If you can't, then you need another fix.

Tip: if you want to dig further in this subject, you might ask thiago on #qt 
on freenode, he's the Qt core maintainer.

Kinds regards, Lisandro.

-- 
Programming is really just the mundane aspect of expressing a solution to a
problem. There are talents that are specifically related to actually coding,
but the real issue is being able to grasp problems and devise solutions that
are detailed enough to actually be coded.
  John Carmack answers on Slashdot,
  http://slashdot.org/games/99/10/15/1012230.shtml

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: