[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#735488: Qt4 in arm64: wrap up of the current situation



Mark: as per [0] Thiago (upstream for qtcore) says:

+#ifndef Q_DATA_MEMORY_BARRIER
+# define Q_DATA_MEMORY_BARRIER asm volatile("dmb sy\n":::"memory")
+#endif
+#ifndef Q_COMPILER_MEMORY_BARRIER
+# define Q_COMPILER_MEMORY_BARRIER asm volatile("":::"memory")

  This shouldn't be necessary anymore if we're using the compilr intrinsics
  with the right __ATOMIC_xxx macros. The compiler will inser the proper
  barriers.

Would it be possible to fix it?


[0] <https://codereview.qt-project.org/#patch,all_unified,81011,3>

For everyone but specially Wookey who wants the patchs in Debian, quoting 
upstream WRT -fpermissive:

  That error needs to be fixed in the right place. Adding -fpermissive to
  make the error disappear without fixing the problem is not the right
  solution.

So as I said before, this needs to get fixed before merging the patches.

As a wrap-up of the push-to-upstream actions, the mostly objected part if the 
-fpermissive flag.

-- 

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


Reply to: