Re: Bug#741190: qt4-x11: Improve atomic support on parisc
On Monday 10 March 2014 10:52:23 John David Anglin wrote:
> On 3/10/2014 9:06 AM, Lisandro Damián Nicanor Pérez Meyer wrote:
> > tag 741190 moreinfo
> > thanks
> >
> > Hi Jhon! This seems an interesting bugfix for Qt4, if there any chance for
> > you to push it upstream?
>
> As it stands, the patch is only applicable to linux. On parisc,
> kernel support is required to implement GCC's atomic builtins and
> linux is the only system with this support.
>
> I have no clue as to whether Qt will build on hpux or openbsd. If
> not, the change could go upstream as is. Otherwise, we need to keep
> the old atomic code for hpux and openbsd.
I think not, so the best thing here would be to you to push it upstream.
Please note I would really love to do it myself, but I can't due to Qt's CLA.
You need to sign up in upstream's gerrit instance and push the patch there.
Of course, **do not hesitate** in asking me for help if needed. Once you have
pushed the patch upstream, also don't forget to add me as reviewer, at that
point I might be of even more help :)
> The patch changes the atomic interface and this affects quite a few
> packages using qt4-x11. Since hppa has been back in ports, we have
> been building qt4-x11 unstable with this change.
That's the perfect reason for upstream to accept it, don't forget to mention
it!
Thanks!
--
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
Reply to: