[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#735488: Qt4 in arm64: wrap up of the current situation



+++ Marcin Juszkiewicz [2014-01-27 17:41 +0100]:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> W dniu 23.01.2014 18:57, Lisandro Damián Nicanor Pérez Meyer pisze:
> > I've tried to summarize the current arm64 situation. The following are my 
> > conclusions, feel free to point if something is wrong, give more 
> > info/feedback, etc.
> 
> As you know from my blog post [0] Qt/AArch64 patch has long history.
> 
> 0.
> http://marcin.juszkiewicz.com.pl/2014/01/20/the-story-of-qtaarch64-patching/
> 
> > = Stuff under debian/
> > 
> > - As explained in a mail before, we don't like the idea of passing
> > -fpermissive as it can lead to very strange crashes. The code will need proper 
> > fixing.
> > 
> > - We are building webkit with a separate source, -no-javascript-jit and the 
> > relevant webkit patches should be applied in src:qtwebkit. The relevant 
> > patches contained in the patch submitted by Wookey come from Riku Voipio and 
> > seems too similar to other patches we already have there, so it should not be 
> > a problem to apply them once we have Qt4 ready form arm64.
> 
> > - It uses linux-g++ instead of linux-g++-64. While that could be the best fit, 
> > it would be good to know why.
> 
> Maybe it is because linux-g++ may use '-m64' argument for GCC which
> AArch64 does not support so build fails.

I think this is correct. I recall hitting that issue. There was also
stuff to do with selecting /lib64 vs /lib IIRC. (/lib is correct for
arm64/aarch64).

> > = Code patches
> > 
> > aarch64.patch:
> > - *No copyright* nor license. We need this at least to be able to apply it and 
> > ask upstream if they see it fit. There's the chance that some code comes from 
> > Ubuntu people.
> 
> 
> > - Webkit stuff: as described above.
> 
> If you need that for something:
> 
> Author: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl> based on
> gtkwebkit changes by Riku Voipio <riku.voipio@linaro.org>
> 
> License: same as upstream one
> 
> > aarch64_fix_atomic_set.patch:
> > - Copyright present.
> > - Possibly needs the above patch applied.
> 
> It requires aarch64.patch as it just change two lines.
> 
> > = Some extra remarks
> > 
> > We need at least the proper copyright and license for the patches. In that way 
> > I'm able to apply them in the package and ping upstream wrt them.
> > 
> > Of course, if the original author can push it to upstream's gerrit the better, 
> > because in case some objection arises I don't need to be in the middle as a 
> > (possibly noisy) proxy.
> 
> Qt4 patches are not accepted upstream. All new code has to go to Qt5 and
> since 5.2.0 QAtomics stuff is using std::atomic so compiler takes care
> of it and there is no code for separate architectures.

Are QT4 patches going to be accepted at some point or will distros have
to carry an arm64 patch for QT4 as long as it remains supported?

Wookey
-- 
Principal hats:  Linaro, Emdebian, Wookware, Balloonboard, ARM
http://wookware.org/


Reply to: