On Wednesday 15 January 2014 18:17:19 Wookey wrote:
> Source: qt4-x11
> Version: 4.8.5
> Severity: normal
> Tags: patch
> User: debian-arm@lists.debian.org
> Usertag: arm64
>
> This package fails to build on arm64 without this patch. It is largely
> based on the ubuntu patches in 4:4.8.4+dfsg-0ubuntu15,
> 4:4.8.4+dfsg-0ubuntu17, and the important fix in
> 4:4.8.4+dfsg-0ubuntu18), but has a few changes.
>
> 1) It uses autotools-dev and the dh_ helpers to ensure config.{sub,guess}
> are up to date rather than patching them directly. This is cleaner, will
> keep working in the future, and allows rebuilds as the clean target works
> correctly.
This part I like it, I'll try to test it soon.
> 2) It uses linux-g++ PLATFORM and adds the -fpermissive CFLAG to enable
> it to build rather than defining a new almost-identical
> linux-g++-aarch64 PLATFORM because that seems to be unnecessary and less
> clean. However I am no QT expert so there may be a good reason for doing
> it the other way. I have left that definition file in so you can see
> what was done, but so far as I can see the linux-g++ definitions are
> correct. A look at why -fpermissive is needed might be a good thing, but
> is beyond my ken.
I'll take a look.
> 3) The ubuntu patch disabled the docs build, but that is now working
> correctly so no need for that any more.
>
> This is obviously an important package in the bootstrap so I hope this
> patch can go in the archive reasonably soon. Obviously I am happy to
> answer questions if you have any queries about what is correct for the
> arm64/aarch64 build.
If it where just patches to debian/* stuff I would have really no problem. But
as this patches touches upstream's stuff like
src/corelib/arch/qatomic_aarch64.h , configure, qmake.conf et al, we ask first
for an upstream's ACK. But to do this the **author** of the changes needs to
push the patches to gerrit and get it either accepted into the Qt4 tree or at
least ACKed by upstream (because maybe they don't want to extend the
funcionality of Qt 4 anymore).
As we have gerrit in the middle (and so the Qt CLA) I'm not able to forward
the patches anymore.
If the author pushes the patches to gerrit please tell him/her to add me as
reviewer, same for the bug she(he could fill to get attention on it.
Kinds regards, Lisandro.
--
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
Attachment:
signature.asc
Description: This is a digitally signed message part.