tag 729187 moreinfo thanks On Sunday 10 November 2013 00:48:13 Aurelien Jarno wrote: > Package: qtbase-opensource-src > Version: 5.1.1+dfsg-5 > Severity: important > Tags: patch upstream > Justification: fails to build from source [snip] > The patch below does exactly that. With it I was able to fully build Qt5 > on a MIPS system. Would it be possible to include it in the next upload? > Thanks in advance. Hi Aurelien! First of all, thank *you* for doing this patch and explain it so clearly :) Allow me to make you some questions, which totally comes from my lack of knowledge wrt this. 1) Is it possible to surround this with something like #ifdef..#elseif..#blah? In other words, to detect if MIPS32 ISA or MIPS2 ISA is being used? If so, I would like to add those statements in order to have both options avilable and try to push the patch upstream. Or maybe I'm not understanding your explanation enough and the code itself works in all cases (but even then, maybe using defines gets faster code for MIPS32 ISA machines). 2) Supposing (1) above is possible: upstream wants patches trough Gerrit, so they know that people submitting them have agreed to the CLA. Would you mind to submit it to upstream's gerrit? In this way you will get the credit for it. Else I could do it on my self, but that doesn't feels correct at all. Of course, if (1) is not possible, I'll keep it as a Debian patch. Kinds regards, and thanks again, Lisandro. -- [snip]Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/
Attachment:
signature.asc
Description: This is a digitally signed message part.