[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#702824: marked as done (calligrasheets: crash when entering double-quotes and some other special characters in formula)



Your message dated Sat, 16 Mar 2013 14:49:29 +0000
with message-id <E1UGsQL-0000TH-A4@franck.debian.org>
and subject line Bug#702824: fixed in calligra 1:2.4.4-3
has caused the Debian Bug report #702824,
regarding calligrasheets: crash when entering double-quotes and some other special characters in formula
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
702824: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702824
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: calligrasheets
Version: 1:2.4.4-2
Severity: important
Tags: patch

When entering:

="

In a cell, calligra sheets crash when entering the double quote.
This disable the usability of using double-quotes in formula

This bug has been reported upstream:
https://bugs.kde.org/show_bug.cgi?id=304825 and has been corrected (but not
verified)

The commit that corrected the bug is here (there is also a link in the bug page
comment 1 from Marijn Kruisselbrink):
http://quickgit.kde.org/?p=calligra.git&a=commit&h=8d91c11ccbe80367e1960db6309c294d2d92f69b


The attached patches are directly from the commit.



-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.35backlightfix (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages calligrasheets depends on:
ii  calligra-libs      1:2.4.4-2
ii  kde-runtime        4:4.8.4-2
ii  libc6              2.13-38
ii  libgcc1            1:4.7.2-5
ii  libgsl0ldbl        1.15+dfsg.2-2
ii  libkcmutils4       4:4.8.4-4
ii  libkde3support4    4:4.8.4-4
ii  libkdecore5        4:4.8.4-4
ii  libkdeui5          4:4.8.4-4
ii  libkhtml5          4:4.8.4-4
ii  libkio5            4:4.8.4-4
ii  libknotifyconfig4  4:4.8.4-4
ii  libkparts4         4:4.8.4-4
ii  libkrosscore4      4:4.8.4-4
ii  libqt4-dbus        4:4.8.2+dfsg-11
ii  libqt4-qt3support  4:4.8.2+dfsg-11
ii  libqt4-sql         4:4.8.2+dfsg-11
ii  libqt4-xml         4:4.8.2+dfsg-11
ii  libqtcore4         4:4.8.2+dfsg-11
ii  libqtgui4          4:4.8.2+dfsg-11
ii  libstdc++6         4.7.2-5
ii  zlib1g             1:1.2.7.dfsg-13

calligrasheets recommends no packages.

Versions of packages calligrasheets suggests:
ii  khelpcenter4  4:4.8.4-2

-- no debconf information
--- a/sheets/Formula.cpp
+++ b/sheets/Formula.cpp
@@ -656,7 +656,8 @@
     tokens.reserve(50);
 
     ++data;
-    const QChar *start = data;
+    const QChar * const start = data;
+    const QChar * const end = start + expr.length();
     const QChar *tokenStart = data;
     const QChar *cellStart = data;
 
@@ -667,9 +668,9 @@
     QString token(length, QChar());
     token.reserve(length); // needed to not realloc at the resize at the end
     QChar * out = token.data();
-    QChar * outStart = token.data();
-
-    while (state != Finish) {
+    QChar * const outStart = token.data();
+
+    while (state != Finish && data < end) {
         switch (state) {
         case Start:
             tokenStart = data;
@@ -1060,7 +1061,7 @@
     }
 
     // parse error if any text remains
-    if (!data->isNull())  {
+    if (data+1 < end)  {
         tokens.append(Token(Token::Unknown, expr.mid(tokenStart - start), tokenStart - start));
         parseError = true;
     }
--- a/sheets/tests/TestFormula.cpp
+++ b/sheets/tests/TestFormula.cpp
@@ -177,9 +177,13 @@
     // invalid formulas, can't be parsed correctly
     CHECK_TOKENIZE("+1.23E", QString());
 
+    // incomplete formulas
+    CHECK_TOKENIZE("COMPARE(\"", "xo");
+    CHECK_TOKENIZE("SHEETS(Sheet2!", "");
+
     // empty parameter
     CHECK_TOKENIZE("IF(A1;A2;)", "xococoo");
-    CHECK_TOKENIZE("=OFFSET(Sheet2'!B7;0;0)", "");
+    CHECK_TOKENIZE("OFFSET(Sheet2'!B7;0;0)", "");
 
     // function cascade
     CHECK_TOKENIZE("SUM(ABS(-1);ABS(-1))", "xoxooiooxooioo");

--- End Message ---
--- Begin Message ---
Source: calligra
Source-Version: 1:2.4.4-3

We believe that the bug you reported is fixed in the latest version of
calligra, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 702824@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adrien Grellier <adrien.grellier@laposte.net> (supplier of updated calligra package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 15 Mar 2013 21:46:18 +0100
Source: calligra
Binary: calligra karbon kexi kexi-calligrasheets-driver kexi-mysql-driver kexi-postgresql-driver kexi-xbase-driver kexi-sybase-driver kexi-web-form-widget kexi-map-form-widget calligra-reports-web-element calligra-reports-map-element krita krita-data kthesaurus calligrasheets calligraplan calligrawords calligrawords-data calligrastage calligraflow calligraflow-data braindump calligramobile calligra-libs calligra-data okular-backend-odp calligra-dbg
Architecture: source all amd64
Version: 1:2.4.4-3
Distribution: unstable
Urgency: low
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Adrien Grellier <adrien.grellier@laposte.net>
Description: 
 braindump  - ideas organizer application for the Calligra Suite
 calligra   - extensive productivity and creative suite
 calligra-data - common shared data for the Calligra Suite
 calligra-dbg - debugging symbols for Calligra
 calligra-libs - common libraries and binaries for the Calligra Suite
 calligra-reports-map-element - map element for Calligra Reports
 calligra-reports-web-element - web element for Calligra Reports
 calligraflow - flowcharting program for the Calligra Suite
 calligraflow-data - data files for Flow flowcharting program
 calligramobile - version of Calligra for mobile
 calligraplan - integrated project management and planning tool
 calligrasheets - spreadsheet for the Calligra Suite
 calligrastage - presentation program for the Calligra Suite
 calligrawords - word processor for the Calligra Suite
 calligrawords-data - data files for Words word processor
 karbon     - vector graphics application for the Calligra Suite
 kexi       - integrated database environment for the Calligra Suite
 kexi-calligrasheets-driver - Tables plugin for kexi
 kexi-map-form-widget - map form widget for Kexi
 kexi-mysql-driver - MySQL support for kexi
 kexi-postgresql-driver - PostgreSQL support for kexi
 kexi-sybase-driver - Sybase support for kexi
 kexi-web-form-widget - web form widget for Kexi
 kexi-xbase-driver - XBase support for kexi
 krita      - pixel-based image manipulation program for the Calligra Suite
 krita-data - data files for Krita painting program
 kthesaurus - thesaurus for the Calligra Suite
 okular-backend-odp - Okular backend for ODP documents
Closes: 702824
Changes: 
 calligra (1:2.4.4-3) unstable; urgency=low
 .
   * import patch fix_tokenizing_of_invalid_formulas.patch from upstream
     (Closes: #702824). It prevent a important crash when entering some special
     characters in formula.
Checksums-Sha1: 
 38bce8bb1210da3d50064de2906bfde246951ccd 4206 calligra_2.4.4-3.dsc
 b2cab3533a61076cd102e32626169b2c3d2e9a17 35207 calligra_2.4.4-3.debian.tar.gz
 63a91272b7092644345689b83d8ea85d6c718fce 12116 calligra_2.4.4-3_all.deb
 6ad095ab8f0054372846bdab658e989044c0b067 687926 karbon_2.4.4-3_amd64.deb
 3d88c1abc968182c44ac8c31e597313937dc3726 3506424 kexi_2.4.4-3_amd64.deb
 eb3e95c9be49e7999e6202705e4f2840dc410b05 24058 kexi-calligrasheets-driver_2.4.4-3_amd64.deb
 ed8001a4cfce01ee714ead9c20b874e02920b7ba 57704 kexi-mysql-driver_2.4.4-3_amd64.deb
 a9c248d0a2a9aa42f961945c9cfd3ad5adb79af5 80724 kexi-postgresql-driver_2.4.4-3_amd64.deb
 91ad01035f035548ae1f6aca7aad65a819ce7b60 56470 kexi-xbase-driver_2.4.4-3_amd64.deb
 baec8eada59cb56316b87bc6361c94e50c103117 64284 kexi-sybase-driver_2.4.4-3_amd64.deb
 baebd0cd0cc53d14f07b93269085d21ae0d63299 29132 kexi-web-form-widget_2.4.4-3_amd64.deb
 5e6c9bfd1b23ae1d44f466f953c266834df3f09e 29000 kexi-map-form-widget_2.4.4-3_amd64.deb
 dd85ce336612a5f1ae929af2470f14b1f620b4a6 30432 calligra-reports-web-element_2.4.4-3_amd64.deb
 45dd88ab608859c7fe75012ed0ba77d1fdf4288c 37914 calligra-reports-map-element_2.4.4-3_amd64.deb
 fa46e1f2c764783e6f6663d76b04ce6640ceecc9 6363654 krita_2.4.4-3_amd64.deb
 5f97e16b32de79ebdbc407966f4862b28474d5e5 19700984 krita-data_2.4.4-3_all.deb
 4286b846543fe3426b6f574b51ffbec2e9fcb81b 28092 kthesaurus_2.4.4-3_amd64.deb
 fee7469b1fa9e6fcb24be521655ffd99ea220daf 4441366 calligrasheets_2.4.4-3_amd64.deb
 8efd23f07d06ff6856cd431ec4f3deb0ed6a867b 2215668 calligraplan_2.4.4-3_amd64.deb
 9c868166b089ba949442245ac133591760524dd7 2608858 calligrawords_2.4.4-3_amd64.deb
 5dce529ac0b6582f67133a667015c5412541558d 490576 calligrawords-data_2.4.4-3_all.deb
 664550e13c8b5c54799e8ab46c2ce9bf3c6050c5 8076372 calligrastage_2.4.4-3_amd64.deb
 1738e86c995bccc4f20c1dd3058e858626e5ad33 79628 calligraflow_2.4.4-3_amd64.deb
 04b818fda49d100ed4490ef82f539cbb156363af 6190768 calligraflow-data_2.4.4-3_all.deb
 558c0a7c96476f43d499e84750bc363102e4c131 286242 braindump_2.4.4-3_amd64.deb
 433215b673e3b24803efc1cd64a12c6c46e011c7 377296 calligramobile_2.4.4-3_amd64.deb
 caa0942e96b997825a708b9a213d143da3a01d10 6574924 calligra-libs_2.4.4-3_amd64.deb
 2b9ec9ac8d630a2ca7b45d561d26b2197f934fd3 1526460 calligra-data_2.4.4-3_all.deb
 b047097972725e01b2f1f90956912c26f3fe3a6b 23678 okular-backend-odp_2.4.4-3_amd64.deb
 5084c7039f10c025911dc82c77bff080cae855d3 334625304 calligra-dbg_2.4.4-3_amd64.deb
Checksums-Sha256: 
 706b60664184b93a87fd787e343a861c77e33021cf03743d87279c842230cc84 4206 calligra_2.4.4-3.dsc
 7bda66aae6406405d4d92ae37f5e5c72fefba7974c6b952c9fdfd1014dad99d2 35207 calligra_2.4.4-3.debian.tar.gz
 2c7ab1e5c999a4953bfeeed6afd393c321d18e04e7d3f3531016e6b351b757b1 12116 calligra_2.4.4-3_all.deb
 8a6046f8d8d5c164e752361f80f8c59e59e0563767bdcb41c1911990ba0c7453 687926 karbon_2.4.4-3_amd64.deb
 b546e2ca57e11a08a04118d0089cf0480842127d5fdc98550442d587e52fc7cd 3506424 kexi_2.4.4-3_amd64.deb
 358e6d9e57fe66aa82406f8fd56d68aacc360f56f20e7201a102d823ecac6d00 24058 kexi-calligrasheets-driver_2.4.4-3_amd64.deb
 e8e6bc9a8d7ebaf003e0ecf1dd7fc1f9cc08d926125212e5b79dea4f11987b97 57704 kexi-mysql-driver_2.4.4-3_amd64.deb
 d04d36d1781af10633b48d47eebb56d3bf04c35adc55a8760ab5a1173ffcd986 80724 kexi-postgresql-driver_2.4.4-3_amd64.deb
 7934eaf995e74c27a250807df86a52714d5e1e9aa6729ff4b580df5e15681f1b 56470 kexi-xbase-driver_2.4.4-3_amd64.deb
 8339f072587e0f062c15142e99243092ebc0aff39f4be3b06b868d37769f676a 64284 kexi-sybase-driver_2.4.4-3_amd64.deb
 54e4957497008242201b86eca80fae192128c66ce84f8c6d53bd05ed040c954b 29132 kexi-web-form-widget_2.4.4-3_amd64.deb
 0dd9c443b9f1b3a5f0c844bf8d23c275e04cc1e478bd05b18837dc3dd37b7f24 29000 kexi-map-form-widget_2.4.4-3_amd64.deb
 9c421ff1216a565cd6842d04e9e444260a072c554570fb53292def7ec9287d97 30432 calligra-reports-web-element_2.4.4-3_amd64.deb
 e84cff54d7de8639976abe51ed95917e2f5fd4805f0256d67ea3a86d5e0795ba 37914 calligra-reports-map-element_2.4.4-3_amd64.deb
 319d6202b5477e06e260e1060dc433d43e063aa2e9d2b9198efae7b0a4b52c8f 6363654 krita_2.4.4-3_amd64.deb
 18b9af9da9a12714335e8867d74846c82a3cf463a8c55710bc5d0aa02a758711 19700984 krita-data_2.4.4-3_all.deb
 68f415e4550a3c565aa264e06f286ec356daaa8cb20f4a15cb6f71283a4fed3e 28092 kthesaurus_2.4.4-3_amd64.deb
 fc52aacaedf729907bfeb4afe585cd669584a13f7249979738b83af0dea6d554 4441366 calligrasheets_2.4.4-3_amd64.deb
 90da4baa7d875fd5e741f3fc4897eff5278281c918346f082463d8b7d16ec9b1 2215668 calligraplan_2.4.4-3_amd64.deb
 0f32c396ff26dc6cbaed55d7a65c5b28cae69e65f925bfca89da0041c979fdf0 2608858 calligrawords_2.4.4-3_amd64.deb
 4b21ed1a6ecbf83b5c07b5f9a3a28e31935bd6e08a94c82788484a2a37391ee1 490576 calligrawords-data_2.4.4-3_all.deb
 65f6d0fc6b4e31f6a4b603fa05443c352e47d853b495008ccd3dce056780c811 8076372 calligrastage_2.4.4-3_amd64.deb
 a4f70825681eb284df35ee62ce60ee926c057dd7f277be821ff107e78a3de9f9 79628 calligraflow_2.4.4-3_amd64.deb
 e8c827208ca7691a4c1c149b7d76be51f39d9966557b1029452a4f6dd45ce6b4 6190768 calligraflow-data_2.4.4-3_all.deb
 26fba081df3fa492601f0c0a1cfa427f461189947155255f8c72cb4d80bd7dba 286242 braindump_2.4.4-3_amd64.deb
 baa1012c1604136137987fd0ecdb4ade5f600409c05c5034f1b5141e34fb72ec 377296 calligramobile_2.4.4-3_amd64.deb
 e8aa12dc838f30d2a129d518f708c0c965d8c81d32aa157be4e5bc6035e7fef9 6574924 calligra-libs_2.4.4-3_amd64.deb
 af62ee25eb980ec60489e2daf1b5b93c6a1aac7f566eba6d757bc0160cf08e6e 1526460 calligra-data_2.4.4-3_all.deb
 7b3d5be6d55f1357be661493cdd5cde31709521a09e7e7b978527408bc003c9d 23678 okular-backend-odp_2.4.4-3_amd64.deb
 75c2fa6b63be5ce98f6597a7e93582eee336f9d474b0a8230abd71531354fbe4 334625304 calligra-dbg_2.4.4-3_amd64.deb
Files: 
 8b4335d14f746f50d978a7495096688c 4206 kde optional calligra_2.4.4-3.dsc
 1897a8e75fb6a497f8757c22a4fa2379 35207 kde optional calligra_2.4.4-3.debian.tar.gz
 011538cc098cc7c8eab9fe88ff1c725d 12116 kde optional calligra_2.4.4-3_all.deb
 6f80db190e129926e7cf24250eb522bc 687926 graphics optional karbon_2.4.4-3_amd64.deb
 0bef0e938ea89be297b3b3bec5b0e99c 3506424 database optional kexi_2.4.4-3_amd64.deb
 819abf51efd27503c3877729d9fad568 24058 kde optional kexi-calligrasheets-driver_2.4.4-3_amd64.deb
 bee8869b68626b49f762c3af99230996 57704 database optional kexi-mysql-driver_2.4.4-3_amd64.deb
 a8b03d49c5ae0db3f0165e508d8a39f3 80724 database optional kexi-postgresql-driver_2.4.4-3_amd64.deb
 344b8f3f1f9a44ed01d67c6d5f9a9e96 56470 database optional kexi-xbase-driver_2.4.4-3_amd64.deb
 9d9ac2d35b964d4fd8932c8260739694 64284 database optional kexi-sybase-driver_2.4.4-3_amd64.deb
 d311a6cb809e193d052e39810b642fca 29132 database optional kexi-web-form-widget_2.4.4-3_amd64.deb
 d9ad2d19b02612ee64f47666861f9a7e 29000 database optional kexi-map-form-widget_2.4.4-3_amd64.deb
 08f97cdf18b9a4d6e5b124a85374deb4 30432 kde optional calligra-reports-web-element_2.4.4-3_amd64.deb
 2ec5ff7025fc00e590f0c412f85983bf 37914 kde optional calligra-reports-map-element_2.4.4-3_amd64.deb
 168ae1e717ba3d32c3631d35d0f9c6c6 6363654 graphics optional krita_2.4.4-3_amd64.deb
 6763c6ec5018cc5785d9a5f1380cf702 19700984 graphics optional krita-data_2.4.4-3_all.deb
 624c2a7332af55988981f4292b3b605d 28092 text optional kthesaurus_2.4.4-3_amd64.deb
 850eb5a0325c49505f544f0bcba710ab 4441366 math optional calligrasheets_2.4.4-3_amd64.deb
 e26a6b916160b4e8916d5d31a53af15d 2215668 kde optional calligraplan_2.4.4-3_amd64.deb
 ee725b3dff599a1b5a4f92848fb9f865 2608858 text optional calligrawords_2.4.4-3_amd64.deb
 ece64d690122afccaf38a234aa90f5ff 490576 text optional calligrawords-data_2.4.4-3_all.deb
 7c0274359e477de87349e1f9de78b6cb 8076372 kde optional calligrastage_2.4.4-3_amd64.deb
 d5eeea80744ba9f1b4f54552e15b4580 79628 graphics optional calligraflow_2.4.4-3_amd64.deb
 37f9ce380d1b311e76a6f8beebec039e 6190768 graphics optional calligraflow-data_2.4.4-3_all.deb
 70bc359aa36f2034bda16a9d7c511f4d 286242 kde optional braindump_2.4.4-3_amd64.deb
 916489c5587ef993e0be1ffc28d3b9d0 377296 kde optional calligramobile_2.4.4-3_amd64.deb
 7594467dae59a9dd6f6d50e1fadf0c5d 6574924 libs optional calligra-libs_2.4.4-3_amd64.deb
 52353ae64c45c6b7536130df73614dc3 1526460 libs optional calligra-data_2.4.4-3_all.deb
 57c141680bac6ef46d9afddbc7bd5124 23678 graphics optional okular-backend-odp_2.4.4-3_amd64.deb
 c941d112cb6a530d5ae16063ff874d42 334625304 debug extra calligra-dbg_2.4.4-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRRHJCAAoJEKtkX0BihqfQimYP/2sRbCJ5CQX3dbjQdoNTEa9f
DB5y685pFJ33FHkdzsSyP0bbZlbpikYJSVsUgBKrbvG3Xx+lFP0pgUpf54Z8MOXx
zTvqQXkAif95OWtJ0UYwy/692BT2qeScjRDSr+KsqMijci5scmJfbRg3a3t3dqtz
QQAmPq8UL4Eo4BiS9n/BSHcVGn1rsZrb3JRdMrNE1EQ2YepI4b+JlXiGLorarNm5
k1prWWYPo7Ag6rRXCqwYUUX/mpesyxVkGCbtehh9xtxtqajQUggLjLhAtsctPUlQ
d0MLmb41qZljygOUaAItc7Mc8ZfkHAGWdHbT+/U1cnRREBLGLvWQv1ofzTstxmZU
6m70CoxaKaMQKcOg8rr6fX3fJpRNJwmlMWF2iebm1OmXViNiO31IK7IRa5COfpPQ
PO/P1l/0gcRHuDC/xy8LYThpXXxC6d6WZRkw9ikUCJkKTsEQZ42zqb3dUVmG8eAE
R5MrVU5mPHkzoNDlA58jsTCW68/b+jYywIzPu6zAzzivDR7D6vThx8Y4Xa132Vus
FARLuyRmJ6otC2dtmOajNghWQJCDH9RO/ae8ocJQRGtr1yB0ZMpFQcQJyKiTERbt
tcjh0dyOl1UGN8QwYbJRM3fSbTaUDDbOh+7udF83kd6LxXqg5OMOWlIPCM1i/FmZ
B/dDNYpazaNBZIW49O67
=ku6t
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: