[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697074: libsolid4: Cannot eject mounted CDs/DVDs



Package: libsolid4
Version: 4:4.8.4-4
Severity: wishlist
Tags: patch

Dear Maintainer,

since upgrading to Wheezy, I cannot eject mounted CDs/DVDs from the
fileplaces panel any more. This bug has already been reported upstream
and has been fixed in KDE 4.9 and 4.10:

https://bugs.kde.org/show_bug.cgi?id=274982

The original patch from the bug report contains a signature mismatch
with udisk's DriveEject method. I'm adding a modified version of the
patch, which I tested successfully.


--- a/solid/solid/backends/udisks/udisksopticaldrive.cpp
+++ b/solid/solid/backends/udisks/udisksopticaldrive.cpp
@@ -62,16 +62,8 @@
 
     QString path = m_device->udi();
 
-    // check if the device is mounted and call umount if needed
-    if (m_device->prop("DeviceIsMounted").toBool())
-    {
-        QDBusMessage msg = QDBusMessage::createMethodCall(UD_DBUS_SERVICE, path, UD_DBUS_INTERFACE_DISKS_DEVICE, "FilesystemUnmount");
-        msg << QStringList();   // options, unused now
-        c.call(msg, QDBus::NoBlock);
-    }
-
     QDBusMessage msg = QDBusMessage::createMethodCall(UD_DBUS_SERVICE, path, UD_DBUS_INTERFACE_DISKS_DEVICE, "DriveEject");
-    msg << QStringList();
+    msg << QStringList(QString("unmount"));
     return c.callWithCallback(msg, this, SLOT(slotDBusReply(QDBusMessage)), SLOT(slotDBusError(QDBusError)));
 }
 


-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-486
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libsolid4 depends on:
ii  libc6        2.13-37
ii  libgcc1      1:4.7.2-4
ii  libqt4-dbus  4:4.8.2+dfsg-6
ii  libqt4-xml   4:4.8.2+dfsg-6
ii  libqtcore4   4:4.8.2+dfsg-6
ii  libqtgui4    4:4.8.2+dfsg-6
ii  libstdc++6   4.7.2-4
ii  libudev0     175-7
ii  udev         175-7

Versions of packages libsolid4 recommends:
ii  udisks  1.0.4-7
ii  upower  0.9.17-1

Versions of packages libsolid4 suggests:
pn  media-player-info  <none>

-- no debconf information


Reply to: