tag 623281 + pending thanks Hi, Alle giovedì 28 aprile 2011, Nobuhiro Iwamatsu ha scritto: > 2011/4/28 Pino Toscano <toscano.pino@tiscali.it>: > > Alle martedì 19 aprile 2011, Nobuhiro Iwamatsu ha scritto: > >> Because In the case of sh4, the architecture is set in 'generic', > >> and use src/corelib/arch/generic/. > > > > Theorically qt4 should build with the 'generic' architecture. > > OK, I misunderstood. > > >> Determining system architecture... > >> (Linux:2.6.33.5-00003-g0ef7fb0-dirty:sh4) Trying 'sh4'... > >> 'sh4' is unsupported, using 'generic' > >> 'sh4' is unsupported, using 'generic' > >> System architecture: 'generic' > >> [...] > >> I made patch to support sh4. Could you apply this patch? > > > > Your patch is based on the code resulting after the qt4-x11 patch > > 07_trust_dpkg-arch_over_uname-m.diff, hence it is wrong. > > Attached there is an attempt of better patch for sh4; could you > > please try it? > > Sure, and I tried. work fine with this patch. Thanks for the fast testing! The patch has been committed to the qt4-x11 debian packaging repository[1], and will be in the next upload to unstable. > > Also, please note that in qt4 there seems to be two sh > > architectures, see the the src/corelib/arch/qatomic_{sh,sh4a}.h > > and the two 'sh' and 'sh4a' directories in src/corelib/arch/; the > > patch you did and the one I just attached use the 'sh' variant > > (which I guess is the generic one for SH). > > Yes, sh in qt4 supprt sh3 and sh4. > sh4a uses the order that sh do not support with these CPU's. > Your patch is right. I see. As also said in #623185, note that switching from 'generic' to the 'sh' architecture is binary incompatible, so you will need to rebuilding every package depending on libqtcore4 after the qt4-x11 upload carrying this fix is uploaded. [1] http://git.debian.org/?p=pkg-kde/qt/qt4- x11.git;a=commit;h=23927e8cd13bfd0f8ec001c180aa0135c6f22b44 -- Pino Toscano
Attachment:
signature.asc
Description: This is a digitally signed message part.