[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#620576: kdelibs: please wipe out dependency_libs from .la files (Policy 10.2)



Package: kdelibs
Version: 4:3.5.10.dfsg.1-5
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu natty ubuntu-patch

Hi folks,

The attached patch has just been applied to the Ubuntu kdelibs package, to
null out the dependency_libs field in the libtool .la file being shipped in
the -dev package.  This is generally a good idea because it avoids causing
consumers of your library to require other .la files listed here to be
available at build time when they're not actually needed (i.e., in the
dynamic linking common case).  It's specifically a good idea right now
because multiarch is imminent, and that means the .la files referenced here
are going to *move* soon, causing build failures for anything using libtool
to build against kdelibs.  As long as kdelibs is going to need a rebuild to
fix up the invalid .la references, it would be nice to get rid of them
altogether.

(Alternatively, since I guess kde3 libs are supposed to be dropped soon, you
might just let this go unfixed and become a FTBFS for reverse-deps?  Your
call...)

Thanks,
--
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org
diff -Nru kdelibs-3.5.10.dfsg.1/debian/rules kdelibs-3.5.10.dfsg.1/debian/rules
--- kdelibs-3.5.10.dfsg.1/debian/rules	2010-10-15 09:41:54.000000000 -0700
+++ kdelibs-3.5.10.dfsg.1/debian/rules	2011-04-02 12:59:52.000000000 -0700
@@ -91,6 +91,11 @@
 	  rm -f LIST; \
 	fi
 
+common-install-arch::
+	for file in debian/tmp/usr/lib/*.la; do \
+		sed -i "/dependency_libs/ s/'.*'/''/" $$file ; \
+	done
+
 common-binary-predeb-indep::
 	-for file in `find ./ -name '*.pot'`; do\
 		if [ ! `echo $$file | grep './po/'` ] && [ ! `echo $$file | grep './debian/'` ]; then\

Reply to: