[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#641753: qt4-x11: QtHelp module has a redundant dependency on QtXml

Package: qt4-x11
Severity: minor
Tags: patch upstream

QtHelp module project and mkspec files make this module and all
applications using it depend on the QtXml library, causing redundant
application and package dependencies. However, the QtHelp module doesn't
use any XML-related classes except QXmlStream* ones which were moved to
QtCore some time ago, so this dependency can be safely removed.

All pre-4.8 Qt versions are affected by this problem. The patch attached
to this report has been accepted by upstream developers for Qt 4.8:

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
commit 02f55668dada4a23ab84e4d3bda1df8a4984b3ae
Author: Constantin Makshin <cmakshin@gmail.com>
Date:   Mon Sep 5 19:43:00 2011 +0200

    Removed the unnecessary dependency of the QtHelp module on the QtXml one
    Merge-request: 2669
    Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>

diff --git a/mkspecs/features/help.prf b/mkspecs/features/help.prf
index 15685e7..99521af 100644
--- a/mkspecs/features/help.prf
+++ b/mkspecs/features/help.prf
@@ -1,4 +1,4 @@
-QT += xml sql
+QT += sql
diff --git a/tools/assistant/lib/lib.pro b/tools/assistant/lib/lib.pro
index 03821b2..d6c3fce 100644
--- a/tools/assistant/lib/lib.pro
+++ b/tools/assistant/lib/lib.pro
@@ -1,5 +1,4 @@
 QT += sql \
-    xml \
 TARGET = QtHelp

Reply to: