[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#636129: marked as done (pkg-kde-tools: dhmk.mk does not honor C(XX)FLAGS set in debian/rules)

Your message dated Sun, 31 Jul 2011 16:12:19 +0300
with message-id <201107311612.23362.modax@debian.org>
and subject line Re: Bug#636129: pkg-kde-tools: dhmk.mk does not honor C(XX)FLAGS set in debian/rules
has caused the Debian Bug report #636129,
regarding pkg-kde-tools: dhmk.mk does not honor C(XX)FLAGS set in debian/rules
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
636129: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636129
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: pkg-kde-tools
Version: 0.14.2
Severity: normal

dhmk.mk does not check whether C(XX)FLAGS are already set,
but unconditionally sets them to the values from dpkg-buildflags.
This means that setting them using e.g. export CFLAGS += ... in 
debian/rules does no longer work.

It should probably check whether those flags are already set,
and only use the value from dpkg-buildflags if they are not.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (102, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0fglrx2 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pkg-kde-tools depends on:
ii  libdpkg-perl                  1.16.0.3   Dpkg perl modules
ii  perl                          5.12.4-2   Larry Wall's Practical Extraction 

Versions of packages pkg-kde-tools recommends:
ii  dpkg-dev                      1.16.0.3   Debian package development tools
ii  libwww-perl                   6.02-1     simple and consistent interface to

Versions of packages pkg-kde-tools suggests:
ii  cdbs                          0.4.96     common build system for Debian pac
ii  debhelper                     8.9.3      helper programs for debian/rules

-- no debconf information

--- End Message ---
--- Begin Message --- 
Hello,

On sekmadienis 31 Liepa 2011 15:24:28 Daniel Schaal wrote:
> dhmk.mk does not check whether C(XX)FLAGS are already set,
> but unconditionally sets them to the values from dpkg-buildflags.
> This means that setting them using e.g. export CFLAGS += ... in
> debian/rules does no longer work.
> 
> It should probably check whether those flags are already set,
> and only use the value from dpkg-buildflags if they are not.

1) Once new dpkg is uploaded, it won't be possible to set additional 
buildflags this way (via CFLAGS +=) in stock dh-based debian/rules. That was a 
deliberate decision by debhelper and dpkg maintainers (or rather known 
collateral damage from other necessary changes) [1]. FYI, new dpkg will cease 
exporting build flags at dpkg-buildpackage level.

2) Having point 1 in mind, this is still not entirely true for dhmk.mk. If 
CFLAGS += etc. appear *after* include ...../{dhmk,debian-qt-kde.mk} it will 
still work. In the short term, IMO, this should be a preferred way to set 
additional flags. However, when newer dpkg is uploaded and gains 
debian/buildflags support, we will see. Diverging from the best practises is 
not a good thing but for now it is not clear how those best practises are 
going to look like since debian/buildflags is not compatible with squeeze.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544844#147

-- 
Modestas Vainius <modax@debian.org>

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
Reply to: