[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#593403: system-config-printer-kde: kcm broken, coding errors

Am 17.08.2010 23:37, schrieb Sune Vuorela:
Package: system-config-printer-kde
Version: 4:4.4.5-1
Severity: grave
Justification: renders package unusable

   File "/usr/share/kde4/apps/system-config-printer-kde/system-config-printer-kde.py", line 1874, in show_HTTP_Error
     KMessageBox.error(self, i18n("There was an HTTP error: %1.", msg), i18n('CUPS server error'))
UnboundLocalError: local variable 'msg' referenced before assignment
kcmshell(14621)/python (plugin): Failed to import module
kcmshell(14621)/kcontrol KCModuleLoader::loadModule: This module has no valid entry symbol at all. The reason could be that it's still using K_EXPORT_COMPONENT_FACTORY with a custom X-KDE-FactoryName which is not supported anymore

adding a bit of spaces at line 1874 to indent it seems to bring up s-c-p-k, but I*m unsure if it is the proper fix.

I think that is the proper fix. It puts the call KMessageBox.error to the else branch. Without it it will also be called if the if branch is selected and msg is not defined.


Reply to: