[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#518511: Patch for the crash



Version: 4:3.5.9-1

This bug is reported in KDE as
https://bugs.kde.org/show_bug.cgi?id=148738

The attached patch solves the problem for me.

>From XCreateImage / XDestroyImage manpage:

"Note that when the image is created using XCreateImage, XGetImage, or
XSubImage, the destroy procedure that the XDestroyImage function calls
frees both the image structure and the data pointed to by the image
structure."
diff -urNad kdenetwork-3.5.9~/krfb/krfb/xupdatescanner.cc kdenetwork-3.5.9/krfb/krfb/xupdatescanner.cc
--- kdenetwork-3.5.9~/krfb/krfb/xupdatescanner.cc	2006-10-01 19:26:23.000000000 +0200
+++ kdenetwork-3.5.9/krfb/krfb/xupdatescanner.cc	2009-08-06 16:15:08.000000000 +0200
@@ -198,8 +198,6 @@
 		shmctl(shminfo_tile.shmid, IPC_RMID, 0);
 	}
 	else {
-		free(tile->data);
-		free(scanline->data);
 		XDestroyImage(scanline);
 		XDestroyImage(tile);
 	}

Reply to: