[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#493727: marked as done (support for latest flash player plugin 10 (beta))



Your message dated Thu, 28 May 2009 22:23:49 -0400
with message-id <200905282223.50121.joshdeb@metzlers.org>
and subject line Fixed in KDE4
has caused the Debian Bug report #493727,
regarding support for latest flash player plugin 10 (beta)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
493727: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493727
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: konqueror-nsplugins
Version: 3.5.9.dfsg.1-5

At present adobe flash player plugin version 10 beta1 (beta2 is bugged) is 
unusable with konqueror-nsplugins (frequently crash).
The revision http://websvn.kde.org/?view=rev&revision=824777 correct this 
problem for kde 4.
I rearrenged the patch to be applied on 3.5.9 version (attached).
With this patch i'm able to use flash 10 beta1 in kde 3.5.9 since June without 
any problem.
Is there any chance to have this patch applied in lenny release of kde?  it 
will make kde 3.5.9 compatible with future release of flash.

Regards,
Andrea.
 
Workaround a certain popular plugin's version 10 beta's inability 
to figure out that 13 < 16.

(AKA, stub out some ABI r16 methods that get called despite us claiming only ABI r13 support.
I could perhaps do more than stuff, but I can't find any docs!)

CCBUG:164706

--- kdebase/nsplugins/sdk/npupp.h	2008/06/26 16:23:48	824776
+++ kdebase/apps/nsplugins/sdk/npupp.h	2008/06/26 16:23:55	824777
@@ -1604,7 +1604,7 @@
 
 #else
 
-typedef bool (* NP_LOADDS NPN_PushPopupsEnabledStateUPP)(NPP npp, NPBool enabled);
+typedef void (* NP_LOADDS NPN_PushPopupsEnabledStateUPP)(NPP npp, NPBool enabled);
 #define NewNPN_PushPopupsEnabledStateProc(FUNC)		\
 		((NPN_PushPopupsEnabledStateUPP) (FUNC))
 #define CallNPN_PushPopupsEnabledStateProc(FUNC, ARG1, ARG2)		\
@@ -1630,7 +1630,7 @@
 
 #else
 
-typedef bool (* NP_LOADDS NPN_PopPopupsEnabledStateUPP)(NPP npp);
+typedef void (* NP_LOADDS NPN_PopPopupsEnabledStateUPP)(NPP npp);
 #define NewNPN_PopPopupsEnabledStateProc(FUNC)		\
 		((NPN_PopPopupsEnabledStateUPP) (FUNC))
 #define CallNPN_PopPopupsEnabledStateProc(FUNC, ARG1)		\
--- kdebase/nsplugins/viewer/nsplugin.cpp	2008/06/26 16:23:48	824776
+++ kdebase/apps/nsplugins/viewer/nsplugin.cpp	2008/06/26 16:23:55	824777
@@ -568,7 +568,19 @@
 
 
 
+/**
+ These two are in the ABI version 16 which we don't claim to support, but 
+ flash uses anyway.
+*/
+static void g_NPN_PushPopupsEnabledState(NPP /*instance*/, NPBool enabled)
+{
+   kdDebug(1431) << "g_NPN_PushPopupsEnabledState() [unimplemented]" << endl;
+}
 
+static void g_NPN_PopPopupsEnabledState(NPP /*instance*/)
+{
+   kdDebug(1431) << "g_NPN_PopPopupsEnabledState() [unimplemented]" << endl;
+}
 
 /******************************************************************/
 
@@ -1437,6 +1449,9 @@
    _nsFuncs.invalidaterect = g_NPN_InvalidateRect;
    _nsFuncs.invalidateregion = g_NPN_InvalidateRegion;
    _nsFuncs.forceredraw = g_NPN_ForceRedraw;
+   
+   _nsFuncs.pushpopupsenabledstate = g_NPN_PushPopupsEnabledState;
+   _nsFuncs.poppopupsenabledstate =  g_NPN_PopPopupsEnabledState;
 
    // initialize plugin
    NPError error = _NP_Initialize(&_nsFuncs, &_pluginFuncs);

--- End Message ---
--- Begin Message ---
Version: 4:4.0.98-1

Looking through KDE's websvn at the versions of kdebase uploaded to Debian, it 
seems this is likely the first KDE4 version that included the fix mentioned 
earlier in this bug report.

Unfortunately a fixed KDE 3.5 did not make it into lenny.

Josh



--- End Message ---

Reply to: