Re: [RFR] templates://kde4libs/{kdelibs5.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
Luckily enough I didn't see anything worth complaining about in the
control file, once I'd got my head round the fact that kdelibs5
provides libraries for KDE 4.
> _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
[...]
> + Some KDE 4 applications are currently running (${apps}). It is recommended
> + to abort the upgrade of kdelibs5, terminate all KDE applications and KDE sessions and try
> upgrading again.
[...]
This phrasing all looks okay, but can you safely put ${apps} in the
middle like that, or is it liable to burst the paragraph? How about
shuffling things like this:
You are about to upgrade to the new version of the kdelibs5 package, which
introduces a major configuration change - details are given in
/usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
from ~/.kde to ~/.kde4). However, some KDE 4 applications are currently
running: ${apps}
.
It is recommended to abort the upgrade of kdelibs5, terminate all KDE
applications and KDE sessions, and try upgrading again.
.
> + If you choose to coontinue the upgrade, [...]
^typo
Oh, in fact there's stuff I'd change here:
> Template: kdelibs5/upgrade_kdehome_info
> Type: note
> _Description: New user settings directory (KDEHOME) for KDE 4 applications
> Once this package is upgraded, KDE 4 applications will use ~/.kde directory to
> store user settings and data (also known as KDEHOME) by default. Currently,
> KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and will
> continue to use) ~/.kde.
Make that:
Once this package is upgraded, KDE 4 applications will use ~/.kde as the default
directory to store user settings and data in (also known as KDEHOME). Currently
KDE 4 applications use ~/.kde4. KDE 3 applications have always used (and will
continue to use) ~/.kde.
> + When the upgrade is complete, it is safe to login to KDE as usual or, if you are
> only using individual KDE 4 applications, you may use Kaboom (available in the
> + package of the same name) wizard to migrate user data before starting a
> KDE 4 application.
"To log in". The "Kaboom (...) wizard" part is slightly awkward but
patching it up spoils the "same name" part. (I hope nobody gets
confused by the package description for madbomber...)
When the upgrade is complete, it is safe to log in to KDE as usual; or, if you
are only using individual KDE 4 applications, you can use the Kaboom wizard (in
the package kaboom) to migrate user data before starting a KDE 4 application.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- kde4libs-4.3.2.pristine/debian/kdelibs5.templates 2009-10-08 07:33:28.000000000 +0100
+++ kde4libs-4.3.2/debian/kdelibs5.templates 2009-10-17 11:17:22.000000000 +0100
@@ -6,27 +6,18 @@
Type: boolean
Default: true
_Description: Stop possible unsafe upgrade of KDE4 with running sessions?
- You are about to upgrade to the new version of the kdelibs5 package which
- introduces a major configuration change. Newly started KDE 4 applications
- will use ~/.kde directory to store user settings and data (also known as
- KDEHOME) by default while currently running KDE 4 applications use ~/.kde4.
- KDE 3 applications have always used (and will continue to use) ~/.kde. It
- seems that there are a few KDE 4 applications running on your system at the
- moment. To avoid potential setting/data loss, you should:
+ You are about to upgrade to the new version of the kdelibs5 package, which
+ introduces a major configuration change - details are given in
+ /usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
+ from ~/.kde to ~/.kde4). However, some KDE 4 applications are currently
+ running: ${apps}
.
- 1) Answer "Yes", terminate all KDE applications and KDE sessions and try
- upgrading again.
+ It is recommended to abort the upgrade of kdelibs5, terminate all KDE
+ applications and KDE sessions, and try upgrading again.
.
- or 2) Answer "No" to continue upgrading. You should make sure that no new
- KDE 4 applications are started before you migrate your KDE 4 settings and
- data. Beware, that clean termination of the old KDE 4 session might not be
- safe..
- .
- Once upgrade is complete, login to KDE as usual or you may use Kaboom wizard
- (package name: kaboom) to migrate your user settings and data before starting
- any KDE 4 application.
- .
- Currently running KDE 4 applications: ${apps}
+ If you choose to continue the upgrade, you should make sure that no new
+ KDE 4 applications are started before KDE 4 settings and data are migrated.
+ A clean termination of the old KDE 4 session might not be safe.
Template: kdelibs5/upgrade_kdehome_info_title
Type: title
@@ -35,12 +26,11 @@
Template: kdelibs5/upgrade_kdehome_info
Type: note
_Description: New user settings directory (KDEHOME) for KDE 4 applications
- Once this package is upgraded, KDE 4 applications will use ~/.kde directory to
- store user settings and data (also known as KDEHOME) by default. Currently,
- KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and will
+ Once this package is upgraded, KDE 4 applications will use ~/.kde as the default
+ directory to store user settings and data in (also known as KDEHOME). Currently,
+ KDE 4 applications use ~/.kde4. KDE 3 applications have always used (and will
continue to use) ~/.kde.
.
- When upgrade is complete, it is safe to login to KDE as usual or, if you are
- only using individual KDE 4 applications, you may use Kaboom (available in the
- package of the same name) wizard to migrate your user data before starting a
- KDE 4 application.
+ When the upgrade is complete, it is safe to log in to KDE as usual; or, if you
+ are only using individual KDE 4 applications, you may use the Kaboom wizard (in
+ the package kaboom) to migrate user data before starting a KDE 4 application.
Template: kdelibs5/upgrade_kdehome_running_title
Type: title
_Description: Upgrading kdelibs5 while KDE 4 is running
Template: kdelibs5/upgrade_kdehome_running
Type: boolean
Default: true
_Description: Stop possible unsafe upgrade of KDE4 with running sessions?
You are about to upgrade to the new version of the kdelibs5 package, which
introduces a major configuration change - details are given in
/usr/share/doc/kdelibs5/README.Debian (in short: user settings are moved
from ~/.kde to ~/.kde4). However, some KDE 4 applications are currently
running: ${apps}
.
It is recommended to abort the upgrade of kdelibs5, terminate all KDE
applications and KDE sessions, and try upgrading again.
.
If you choose to continue the upgrade, you should make sure that no new
KDE 4 applications are started before KDE 4 settings and data are migrated.
A clean termination of the old KDE 4 session might not be safe.
Template: kdelibs5/upgrade_kdehome_info_title
Type: title
_Description: Upgrading kdelibs5
Template: kdelibs5/upgrade_kdehome_info
Type: note
_Description: New user settings directory (KDEHOME) for KDE 4 applications
Once this package is upgraded, KDE 4 applications will use ~/.kde as the default
directory to store user settings and data in (also known as KDEHOME). Currently,
KDE 4 applications use ~/.kde4. KDE 3 applications have always used (and will
continue to use) ~/.kde.
.
When the upgrade is complete, it is safe to log in to KDE as usual; or, if you
are only using individual KDE 4 applications, you may use the Kaboom wizard (in
the package kaboom) to migrate user data before starting a KDE 4 application.
Reply to: