[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#520074: FTBFS on GNU/kFreeBSD



Hi,

As suggested on my patch 77, I would prefer get rid of ucred declaration.
This piece of code is completely outdated and used on older glibc.

On GNU/kFreeBSD, it seems still an issue ?

For details, please take a look at kdesu/kdesud/secure.cpp.
There are three different implementation, only one of the
uses struct ucred. IMHO, in the clean way, the kdesu/kdesud/secure.h should not use struct ucred at all, it should directly include

  pid_t pid;                    /* PID of sending process.  */
  uid_t uid;                    /* UID of sending process.  */
  gid_t gid;                    /* GID of sending process.  */

and the implementation with struct ucred should copy these values.
The comment "`struct ucred' is not defined in glibc 2.0." is not the correct one.

I proposed a minimal patch, which should solve both linux and GNU/kFreeBSD failure with pristine kdebase code.

afaics, the ftbfs isn't caused by ucred structure:
/bin/sed: can't read /usr/lib/libjack.la: No such file or directory
libtool: link: `/usr/lib/libjack.la' is not a valid libtool archive

In fact, now it is. The kdelibs have been binNMUed to get rid of libjack.la reference. See last build log from
http://buildd.debian-ports.org/build.php?pkg=kdebase&arch=kfreebsd-i386&ver=4:3.5.10.dfsg.1-1
http://buildd.debian-ports.org/build.php?pkg=kdebase&arch=kfreebsd-amd64&ver=4:3.5.10.dfsg.1-1
to get current failure reason.

Petr




Reply to: