[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#494427: plasma: emptying trash from the trash plasmoid does not notify about trash changes



On Sat, Aug 09, 2008 at 03:02:08PM +0300, George Kiagiadakis wrote:
> Package: kdebase-workspace
> Version: 4:4.1.0-1
> Severity: normal
> Tags: patch
> 
> Steps to reproduce:
> 1) Have an empty trash
> 2) delete something from dolphin
> 3) go to trash in dolphin
> 4) click to empty trash from the trash plasmoid.
> You will notice that the trash plasmoid still says that there are items in trash
> and dolphin still shows those items. If you press f5 to reload dolphin, the items
> will disappear but the trash plasmoid will remain like this forever.
> 
> The problem relies in the fact that dolphin calls directly ktrash to empty the trash
> and ktrash in turn uses dbus to notify other processes about the changes.
> However, in debian, ktrash from kde4 is renamed to ktrash4 and as a result, the kde3
> version of ktrash is called. This sends the signal over dcop and kde4 processes never
> get informed.
> 
> This patch should solve the issue:
> ======================
> diff -uprN kdebase-workspace-4.1.0/plasma/applets/trash/trash.cpp kdebase-workspace-4.1.0-fixed/plasma/applets/trash/trash.cpp
> --- kdebase-workspace-4.1.0/plasma/applets/trash/trash.cpp      2008-07-15 22:48:49.000000000 +0300
> +++ kdebase-workspace-4.1.0-fixed/plasma/applets/trash/trash.cpp        2008-08-09 14:38:12.000000000 +0300
> @@ -193,7 +193,7 @@ void Trash::slotEmpty()
>          // we can simply call ktrash.
>          //KonqOperations::emptyTrash(&m_menu);
>          KProcess process;
> -        process << KStandardDirs::findExe("ktrash") << "--empty";
> +        process << KStandardDirs::findExe("ktrash4") << "--empty";
>          process.execute();
> 
>      }
> ======================
>

Thanks for the patch! Please, submit it to bugs.kde.org so it can get applied
direclty in KDE's SVN.

Ana



Reply to: