Bug#484770: koffice_1.6.3-5(unstable/arm|armel): error: 'malloc' was not declared in this scope
Package: koffice
Version: 1.6.3-5
Severity: serious
Tags: patch
Justification: fails to build from source
>From my build log:
from /build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxconnection.h:26,
from /build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxdriver.cpp:25:
/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/../../../kexidb/cursor.h:256: warning: 'typedef' was ignored in this declaration
/bin/sh ../../../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../../../.. -I/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx -I/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/../../.. -I/usr/include/kde -I/usr/share/qt3/include -I. -I/usr/include/postgresql -I/usr/include -DKEXI_SCRIPTS_SUPPORT -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -g -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DHAVE_KNEWSTUFF -fexceptions -include /build/buildd/koffice-1.6.3/./kexi/kexi_global.h -DKEXI_NO_CURSOR_PROPERTY -DKEXI_NO_CTXT_HELP -DKEXI_NO_SUBFORM -DKEXI_DB_COMBOBOX_WIDGET -DDB_TEMPLATES -DKEXI_DEBUG_GUI -DKEXIDB_PGSQL_DRIVER_EXPORT= -D__KEXIDB__= -include /build/buildd/koffice-1.6.3/./kexi/kexidb/global.h -c -o pqxxcursor.lo /build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxcursor.cpp
g++ -DHAVE_CONFIG_H -I. -I../../../.. -I/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx -I/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/../../.. -I/usr/include/kde -I/usr/share/qt3/include -I. -I/usr/include/postgresql -I/usr/include -DKEXI_SCRIPTS_SUPPORT -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -g -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DHAVE_KNEWSTUFF -fexceptions -include /build/buildd/koffice-1.6.3/./kexi/kexi_global.h -DKEXI_NO_CURSOR_PROPERTY -DKEXI_NO_CTXT_HELP -DKEXI_NO_SUBFORM -DKEXI_DB_COMBOBOX_WIDGET -DDB_TEMPLATES -DKEXI_DEBUG_GUI -DKEXIDB_PGSQL_DRIVER_EXPORT= -D__KEXIDB__= -include /build/buildd/koffice-1.6.3/./kexi/kexidb/global.h -c /build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxcursor.cpp -fPIC -DPIC -o .libs/pqxxcursor.o
In file included from /build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxcursor.h:23,
from /build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxcursor.cpp:20:
/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/../../../kexidb/cursor.h:256: warning: 'typedef' was ignored in this declaration
/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxcursor.cpp: In member function 'virtual const char** KexiDB::pqxxSqlCursor::rowData() const':
/build/buildd/koffice-1.6.3/./kexi/kexidb/drivers/pqxx/pqxxcursor.cpp:262: error: 'malloc' was not declared in this scope
make[6]: *** [pqxxcursor.lo] Error 1
make[6]: Leaving directory `/build/buildd/koffice-1.6.3/obj-arm-linux-gnu/kexi/kexidb/drivers/pqxx'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory `/build/buildd/koffice-1.6.3/obj-arm-linux-gnu/kexi/kexidb/drivers'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/build/buildd/koffice-1.6.3/obj-arm-linux-gnu/kexi/kexidb'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/build/buildd/koffice-1.6.3/obj-arm-linux-gnu/kexi'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd/koffice-1.6.3/obj-arm-linux-gnu'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/build/buildd/koffice-1.6.3/obj-arm-linux-gnu'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
******************************************************************************
Build finished at 20080531-1559
FAILED [dpkg-buildpackage died]
The problem is due to missing includes and appears when:
- g++ 4.3 is used
- --enable-final is not used
Currently this concerns arm and armel. The patch below fixes the
problem.
--- koffice-1.6.3.orig/filters/kword/wordperfect/import/TextRunStyle.cxx
+++ koffice-1.6.3/filters/kword/wordperfect/import/TextRunStyle.cxx
@@ -33,6 +33,8 @@
#include "WriterProperties.hxx"
#include "DocumentElement.hxx"
+#include <cstring>
+
#ifdef _MSC_VER
#include <minmax.h>
#endif
--- koffice-1.6.3.orig/filters/kword/wordperfect/import/TableStyle.cxx
+++ koffice-1.6.3/filters/kword/wordperfect/import/TableStyle.cxx
@@ -27,6 +27,7 @@
/* "This product is not manufactured, approved, or supported by
* Corel Corporation or Corel Corporation Limited."
*/
+#include <cstring>
#include <math.h>
#include "FilterInternal.hxx"
#include "TableStyle.hxx"
--- koffice-1.6.3.orig/kexi/kexidb/drivers/pqxx/pqxxcursor.cpp
+++ koffice-1.6.3/kexi/kexidb/drivers/pqxx/pqxxcursor.cpp
@@ -27,6 +27,8 @@
#include <klocale.h>
#include <kdebug.h>
+#include <cstdlib>
+
using namespace KexiDB;
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (500, 'unstable')
Architecture: armel (armv5tejl)
Kernel: Linux 2.6.25-1-versatile
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to fr_FR.UTF-8)
Shell: /bin/sh linked to /bin/bash
Reply to: