[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#473459: juic: bashism in /bin/sh script



Raphael Geissert wrote:

> While performing an archive wide checkbashisms (from the 'devscripts'
> package) check I've found your package containing a /bin/sh script
> making use of a bashism.
> 
> checkbashisms' output:
> > possible bashism in ./usr/bin/juic line 19 (pushd):
> >     pushd `dirname ${ls##* }` >/dev/null
> > possible bashism in ./usr/bin/juic line 21 (popd):
> >     popd >/dev/null

Although this a bashism, the code is never run as 018-juic-uixsldir.diff
hardcodes the dir:

  --- kdebindings/qtjava/designer/juic/bin/juic
  +++ kdebindings/qtjava/designer/juic/bin/juic
  @@ -43,8 +43,7 @@
   #              common/
   #              java
   
  -a=$(getAbsolutePath $0)
  -UIXSLDIR=$(dirname "$a")
  +UIXSLDIR=/usr/share/juic
   UIXSL=${UIXSLDIR}/juic.xsl
 
   ABSTRACT="true"


Regards,

-- 
Chris Lamb, UK                                       chris@chris-lamb.co.uk
                                                            GPG: 0x634F9A20

Attachment: signature.asc
Description: PGP signature


Reply to: