[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#432012: kdemultimedia: [juk] add DOCP support for forwardAlbum



Package: kdemultimedia
Version: 3.5.7-2
Severity: wishlist
Tags: patch

Hi,

The attached patch adds support for selecting a (random) next album in 
juk's "Album Random Play" mode. This is a control that was only added in 
later versions of juk, and apparently DOCP support was forgotten.

With the patch applied, I now have full remote control over juk from a 
different system, so I no longer have to awaken the dispay just to skip a 
song I don't like :-)

I understand from Sune that Juk is being phased out upstream (which IMO is 
a pity), but please consider including this patch in Debian.

I'll send the script I use for the remote control to the debian-kde list.

Cheers,
FJP

--- kdemultimedia-3.5.7.orig/juk/jukIface.h
+++ kdemultimedia-3.5.7/juk/jukIface.h
@@ -64,6 +64,7 @@
     virtual void forward() = 0;
     virtual void seekBack() = 0;
     virtual void seekForward() = 0;
+    virtual void forwardAlbum() = 0;
 
     virtual void volumeUp() = 0;
     virtual void volumeDown() = 0;
--- kdemultimedia-3.5.7.orig/juk/playermanager.cpp
+++ kdemultimedia-3.5.7/juk/playermanager.cpp
@@ -443,6 +443,17 @@
         stop();
 }
 
+void PlayerManager::forwardAlbum()
+{
+    m_playlistInterface->playNextAlbum();
+    FileHandle file = m_playlistInterface->currentFile();
+
+    if(!file.isNull())
+        play(file);
+    else
+        stop();
+}
+
 void PlayerManager::volumeUp()
 {
     if(!player() || !m_sliderAction || !m_sliderAction->volumeSlider())
--- kdemultimedia-3.5.7.orig/juk/playlistinterface.h
+++ kdemultimedia-3.5.7/juk/playlistinterface.h
@@ -65,6 +65,7 @@
 
     virtual void playNext() = 0;
     virtual void playPrevious() = 0;
+    virtual void playNextAlbum() = 0;
     virtual void stop() = 0;
 
     virtual bool playing() const = 0;
--- kdemultimedia-3.5.7.orig/juk/playermanager.h
+++ kdemultimedia-3.5.7/juk/playermanager.h
@@ -78,6 +78,7 @@
     void playPause();
     void forward();
     void back();
+    void forwardAlbum();
     void volumeUp();
     void volumeDown();
     void mute();

Attachment: pgp0KcnNizpiq.pgp
Description: PGP signature


Reply to: