Bug#292765: marked as done (kdelibs4: khtml XMLHttpRequest POST broken due to blank line in headers)
Your message dated Sun, 13 Feb 2005 09:17:29 -0500
with message-id <E1D0KYz-0008RA-00@newraff.debian.org>
and subject line Bug#292765: fixed in kdelibs 4:3.3.2-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Jan 2005 16:07:23 +0000
>From michael@metaparadigm.com Sat Jan 29 08:07:23 2005
Return-path: <michael@metaparadigm.com>
Received: from gort.metaparadigm.com [203.117.131.12]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Cuv86-0006b9-00; Sat, 29 Jan 2005 08:07:22 -0800
Received: from localhost (unknown [127.0.0.1])
by gort.metaparadigm.com (Postfix) with ESMTP id DF0801ACCD
for <submit@bugs.debian.org>; Sun, 30 Jan 2005 00:07:18 +0800 (SGT)
Received: from gort.metaparadigm.com ([127.0.0.1])
by localhost (gort [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
id 20568-09 for <submit@bugs.debian.org>;
Sun, 30 Jan 2005 00:07:17 +0800 (SGT)
Received: from [192.168.133.2] (cm113.gamma104.maxonline.com.sg [202.156.104.113])
by gort.metaparadigm.com (Postfix) with ESMTP id B37F41ACCA
for <submit@bugs.debian.org>; Sun, 30 Jan 2005 00:07:16 +0800 (SGT)
Message-ID: <41FBB4B3.4020006@metaparadigm.com>
Date: Sun, 30 Jan 2005 00:07:15 +0800
From: Michael Clark <michael@metaparadigm.com>
User-Agent: Debian Thunderbird 1.0 (X11/20050116)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: kdelibs4: khtml XMLHttpRequest POST broken due to blank line in headers
Content-Type: multipart/mixed;
boundary="------------070909040309010705090404"
X-Virus-Scanned: by amavisd-new at gort.metaparadigm.com
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
This is a multi-part message in MIME format.
--------------070909040309010705090404
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Package: kdelibs4
Version: 4:3.3.2-1
Severity: normal
Tags: patch
XMLHttpRequestObject POST does not work due to an additional blank
header line printed in the HTTP headers. This due khtml's XMLHttpRequest
not setting the required content-type metadata for kio http.
See upstream bug http://bugs.kde.org/show_bug.cgi?id=95981
which has now been fixed in upstream CVS.
This would be a nice fix to get into sarge as many modern web apps
are beginning to use this functionality.
Here is a test case. Before the patch is applied you will get an
Exception alert dialog: http://oss.metaparadigm.com/jsonrpc/test.jsp
Attached is patch that was accepted upstream.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.10-mc1-skas3-v7
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages kdelibs4 depends on:
ii kdelibs-bin 4:3.3.2-1 KDE core binaries
ii kdelibs-data 4:3.3.2-1 KDE core shared data
ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi
ii libarts1 1.3.2-2 aRts Sound system
ii libasound2 1.0.8-1 ALSA library
ii libaspell15 0.50.5-5 The GNU Aspell spell-checker runti
ii libaudio2 1.7-2 The Network Audio System (NAS). (s
ii libaudiofile0 0.2.6-5 Open-source version of SGI's audio
ii libbz2-1.0 1.0.2-3 high-quality block-sorting file co
ii libc6 2.3.2.ds1-20 GNU C Library: Shared libraries an
ii libcomerr2 1.36rc5-1 common error description library
ii libcupsys2-gnutls10 1.1.23-3 Common UNIX Printing System(tm) -
ii libesd-alsa0 [libesd0] 0.2.35-2 Enlightened Sound Daemon (ALSA) -
ii libfam0c102 2.7.0-6 client library to control the FAM
ii libgcc1 1:4.0-0pre0 GCC support library
ii libglib2.0-0 2.6.1-3 The GLib library of C routines
ii libice6 4.3.0.dfsg.1-10 Inter-Client Exchange library
ii libidn11 0.5.2-3 GNU libidn library, implementation
ii libjack0.80.0-0 0.99.0-2 JACK Audio Connection Kit (librari
ii libjasper-1.701-1 1.701.0-2 The JasPer JPEG-2000 runtime libra
ii libjpeg62 6b-9 The Independent JPEG Group's JPEG
ii libkrb53 1.3.6-1 MIT Kerberos runtime libraries
ii libmad0 0.15.1b-1 MPEG audio decoder library
ii libogg0 1.1.0-1 Ogg Bitstream Library
ii libopenexr2 1.2.1-3 runtime files for the OpenEXR imag
ii libpcre3 4.5-1.1 Perl 5 Compatible Regular Expressi
ii libpng12-0 1.2.8rel-1 PNG library - runtime
ii libqt3c102-mt 3:3.3.3-8 Qt GUI Library (Threaded runtime v
ii libsm6 4.3.0.dfsg.1-10 X Window System Session Management
ii libstdc++5 1:3.3.5-7 The GNU Standard C++ Library v3
ii libtiff4 3.7.1-2 Tag Image File Format (TIFF) libra
ii libvorbis0a 1.0.1-1 The Vorbis General Audio Compressi
ii libvorbisenc2 1.0.1-1 The Vorbis General Audio Compressi
ii libvorbisfile3 1.0.1-1 The Vorbis General Audio Compressi
ii libx11-6 4.3.0.dfsg.1-10 X Window System protocol client li
ii libxext6 4.3.0.dfsg.1-10 X Window System miscellaneous exte
ii libxml2 2.6.15-2 GNOME XML library
ii libxrender1 0.8.3-7 X Rendering Extension client libra
ii libxslt1.1 1.1.8-5 XSLT processing library - runtime
ii libxt6 4.3.0.dfsg.1-10 X Toolkit Intrinsics
ii xbase-clients 4.3.0.dfsg.1-10 miscellaneous X clients
ii xlibs 4.3.0.dfsg.1-10 X Keyboard Extension (XKB) configu
ii zlib1g 1:1.2.2-4 compression library - runtime
-- no debconf information
--------------070909040309010705090404
Content-Type: text/x-c;
name="khtml-xmlhttprequest-post-fix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="khtml-xmlhttprequest-post-fix.patch"
--- kdelibs-3.3.2/khtml/ecma/xmlhttprequest.h 2004-11-29 01:30:52.000000000 +0800
+++ kdelibs-cvs/khtml/ecma/xmlhttprequest.h 2005-01-29 10:34:10.000000000 +0800
@@ -98,6 +98,7 @@
QString method;
bool async;
QString requestHeaders;
+ QString contentType;
KIO::TransferJob * job;
--- kdelibs-3.3.2/khtml/ecma/xmlhttprequest.cpp 2004-11-29 01:30:52.000000000 +0800
+++ kdelibs-cvs/khtml/ecma/xmlhttprequest.cpp 2005-01-29 10:08:52.000000000 +0800
@@ -110,6 +110,7 @@
const ClassInfo XMLHttpRequest::info = { "XMLHttpRequest", 0, &XMLHttpRequestTable, 0 };
+
/* Source for XMLHttpRequestTable.
@begin XMLHttpRequestTable 7
readyState XMLHttpRequest::ReadyState DontDelete|ReadOnly
@@ -216,6 +217,7 @@
qObject(new XMLHttpRequestQObject(this)),
doc(static_cast<DOM::DocumentImpl*>(d.handle())),
async(true),
+ contentType(QString::null),
job(0),
state(Uninitialized),
onReadyStateChangeListener(0),
@@ -308,6 +310,10 @@
if (method.lower() == "post" && (url.protocol().lower() == "http" || url.protocol().lower() == "https") ) {
// FIXME: determine post encoding correctly by looking in headers for charset
job = KIO::http_post( url, QCString(_body.utf8()), false );
+ if(contentType.isNull())
+ job->addMetaData( "content-type", "Content-type: text/plain" );
+ else
+ job->addMetaData( "content-type", contentType );
}
else
{
@@ -368,6 +374,11 @@
void XMLHttpRequest::setRequestHeader(const QString& name, const QString &value)
{
+ // Content-type needs to be set seperately from the other headers
+ if(name.lower() == "content-type") {
+ contentType = "Content-type: " + value;
+ return;
+ }
if (requestHeaders.length() > 0) {
requestHeaders += "\r\n";
}
--------------070909040309010705090404--
---------------------------------------
Received: (at 292765-close) by bugs.debian.org; 13 Feb 2005 14:23:07 +0000
>From katie@ftp-master.debian.org Sun Feb 13 06:23:07 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D0KeR-0004DD-00; Sun, 13 Feb 2005 06:23:07 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1D0KYz-0008RA-00; Sun, 13 Feb 2005 09:17:29 -0500
From: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
To: 292765-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#292765: fixed in kdelibs 4:3.3.2-2
Message-Id: <E1D0KYz-0008RA-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 13 Feb 2005 09:17:29 -0500
Delivered-To: 292765-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 5
Source: kdelibs
Source-Version: 4:3.3.2-2
We believe that the bug you reported is fixed in the latest version of
kdelibs, which is due to be installed in the Debian FTP archive:
kdelibs-bin_3.3.2-2_i386.deb
to pool/main/k/kdelibs/kdelibs-bin_3.3.2-2_i386.deb
kdelibs-data_3.3.2-2_all.deb
to pool/main/k/kdelibs/kdelibs-data_3.3.2-2_all.deb
kdelibs4-dev_3.3.2-2_i386.deb
to pool/main/k/kdelibs/kdelibs4-dev_3.3.2-2_i386.deb
kdelibs4-doc_3.3.2-2_all.deb
to pool/main/k/kdelibs/kdelibs4-doc_3.3.2-2_all.deb
kdelibs4_3.3.2-2_i386.deb
to pool/main/k/kdelibs/kdelibs4_3.3.2-2_i386.deb
kdelibs_3.3.2-2.diff.gz
to pool/main/k/kdelibs/kdelibs_3.3.2-2.diff.gz
kdelibs_3.3.2-2.dsc
to pool/main/k/kdelibs/kdelibs_3.3.2-2.dsc
kdelibs_3.3.2-2_all.deb
to pool/main/k/kdelibs/kdelibs_3.3.2-2_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 292765@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org> (supplier of updated kdelibs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 13 Feb 2005 04:58:29 +0100
Source: kdelibs
Binary: kdelibs4 kdelibs-bin kdelibs kdelibs4-doc kdelibs-data kdelibs4-dev
Architecture: source i386 all
Version: 4:3.3.2-2
Distribution: unstable
Urgency: high
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Description:
kdelibs - KDE core libraries metapackage
kdelibs-bin - KDE core binaries
kdelibs-data - KDE core shared data
kdelibs4 - KDE core libraries
kdelibs4-dev - KDE core libraries (development files)
kdelibs4-doc - KDE core library documentation
Closes: 270592 290323 292081 292569 292765 294832 294896
Changes:
kdelibs (4:3.3.2-2) unstable; urgency=high
.
+++ Changes by Adeodato Simó:
.
* Include patch to fix CAN-2005-0365, "insecure temporary file creation in
kdelibs 3.3.2". dcopidlng no longer creates its temporary files in /tmp.
(Closes: #294832, #294896) Urgency set to high because of this and other
RC bug fixes below.
.
* KDE_3_3_BRANCH update.
.
* Include patch from CVS to fix XMLHttpRequest POST being broken in KHTML
due to a blank line in headers. (Closes: #292765)
.
+++ Changes by Christopher Martin:
.
* Add patch from upstream that solves the problem wherein programs whose
.desktop entry contained their full path, rather than just the binary
to be executed (mainly games), confused kdeinit.
(Closes: #270592, #290323)
.
* debian/control: Add necessary kdelibs-data Replaces for old
openoffice.org packages. (Closes: #292569)
.
* Add better manpage for lnusertemp. Thanks to Javier Fernández-Sanguino
Peña. (Closes: #292081)
Files:
97bcad06bc3f35a5966d652f31c304ee 1302 libs optional kdelibs_3.3.2-2.dsc
e8fc19fa7b6e05679c0a1685ee7c7ddd 441095 libs optional kdelibs_3.3.2-2.diff.gz
fe0f7edea20e8c0dcdc77a499f1b36bb 854500 libs optional kdelibs-bin_3.3.2-2_i386.deb
e48add20db2debc3583847ae41eac3e7 8186534 libs optional kdelibs4_3.3.2-2_i386.deb
80de26e8a8916a6db994488d55341377 1231148 libdevel optional kdelibs4-dev_3.3.2-2_i386.deb
5ed446dccab56f5f72bce0dbd106a551 18624 kde optional kdelibs_3.3.2-2_all.deb
f1dc691989bb771e344508defeb364b3 7083852 libs optional kdelibs-data_3.3.2-2_all.deb
3ea3e09f919dd12325316ea72b7b4372 11570094 doc optional kdelibs4-doc_3.3.2-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Signed by Isaac Clerencia <isaac@warp.es>
iD8DBQFCD09IQET2GFTmct4RAujUAJ4jDMiVlyGQfPQDRTI1wI9Wiwox2QCePjH7
zeAG5hDal7zM91Z45OA0sgc=
=6tRo
-----END PGP SIGNATURE-----
Reply to: