Bug#245820: kdeutils: FTBFS on powerpc (missing TAG_BRIGHTNESS)

[Petter Reinholdtsen <pere@hungry.com>]

Package:  kdeutils
Version:  4:3.2.2-1
Severity: serious

The source fail to build on powerpc because it is missing the
TAG_BRIGHTNESS constant.  This is the build error:

  Making all in powerbook2
  make[4]: Entering directory
    `/build/buildd/kdeutils-3.2.2/obj-powerpc-linux/kmilo/powerbook2'
  if /bin/sh ../../libtool --silent --mode=compile --tag=CXX g++
    -DHAVE_CONFIG_H -I. -I../../../kmilo/powerbook2
    -I../.. -I../../../kmilo/powerbook2/../kmilod -I/usr/include/kde
    -I/usr/share/qt3/include -I.  -DQT_THREAD_SUPPORT -D_REENTRANT
    -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi
    -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion
    -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings
    -DNDEBUG -DNO_DEBUG -O2 -Wformat-security
    -Wmissing-format-attribute -fno-exceptions -fno-check-new
    -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL
    -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT pb_monitor.lo -MD -MP -MF
    ".deps/pb_monitor.Tpo" -c -o pb_monitor.lo
    ../../../kmilo/powerbook2/pb_monitor.cpp; \
  then mv -f ".deps/pb_monitor.Tpo" ".deps/pb_monitor.Plo"; else rm
    -f ".deps/pb_monitor.Tpo"; exit 1; fi

  ../../../kmilo/powerbook2/pb_monitor.cpp: In member function `virtual
     KMilo::Monitor::DisplayType PowerBookMonitor::poll()':
  ../../../kmilo/powerbook2/pb_monitor.cpp:82: error: `TAG_BRIGHTNESS'
    undeclared
     (first use this function)
  ../../../kmilo/powerbook2/pb_monitor.cpp:82: error: (Each undeclared
    identifier
     is reported only once for each function it appears in.)
  ../../../kmilo/powerbook2/pb_monitor.cpp:103: warning: `and' of mutually
     exclusive equal-tests is always 0
  make[4]: *** [pb_monitor.lo] Error 1
  make[4]: Leaving directory
    `/build/buildd/kdeutils-3.2.2/obj-powerpc-linux/kmilo/powerbook2'

The problem is in this code:

  Monitor::DisplayType PowerBookMonitor::poll()
  {
        Monitor::DisplayType rc = None;
        // Drain the queue, send the last message
        struct tagitem* tag = readMessage();
        m_message = QString::null;
        while ( tag && tag->tag != TAG_END ) {
                switch ( tag->tag ) {
                case TAG_VOLUME:
                        rc = Monitor::Volume;
                        m_progress = (int)tag->data;
                        break;
                case TAG_MUTE:
                        rc = Monitor::Mute;
                        m_progress = (int)tag->data;
                        break;
                case TAG_BRIGHTNESS:
                        rc = Monitor::Brightness;
                        m_progress = ((int)tag->data)*100/15;
                        break;
  [...]

The TAG_BRIGHTNESS constant is not mentioned anywhere else in the
kdeutils source.  I have no idea which header file it belongs to.

Searching on google for TAG_BRIGHTNESS, I come across a document
<URL:http://www.cymes.de/members/joker/projects/pbbuttons/clog-gtkpbbuttons.txt>
mentioning that a constant changed name from TAG_BRIGHTNESS to
TAG_LCDBRIGHTNESS.  Perhaps the source need to be updated to use the
new name?

I do not have a powerpc machine available to test this.