Bug#1065169: debsources: incomplete support for non-free-firmware
Package: qa.debian.org
User: qa.debian.org@packages.debian.org
Usertag: debsources
Severity: important
Hi,
While waiting for an update run on sor.d.o to finish earlier today (so
I could add a little disk space to /srv) I noticed some errors in the
logs relating to non-free-firmware packages; e.g.:
2024-03-01 08:59:19 updater:ERROR failed to add nvidia-graphics-drivers/525.147.05-7~deb12u1
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1276, in _execute_context
self.dialect.do_execute(
File "/usr/lib/python3/dist-packages/sqlalchemy/engine/default.py", line 609, in do_execute
cursor.execute(statement, parameters)
psycopg2.errors.StringDataRightTruncation: value too long for type character varying(8)
This appears to be because MR!6 didn't change the size of the field in
lib/debsources/models.py and "non-free-firmware" is obviously larger
than 8 characters.
I assume this needs a database migration as well as a change to
models.py, but it's not completely clear to me how/when those get
applied, particularly as 011-to-012.sql has existed since early 2020
but models.py still specifies DB_SCHEMA_VERSION as 11.
Regards,
Adam
Reply to: