[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#977367: debsources: search results point to not existing sources?





On Wed, Apr 28, 2021 at 10:36 PM Matthieu Caneill <matt@brokenwa.re> wrote:
Hi Michael,

On Sun, Apr 11, 2021 at 10:41:10AM +0200, Michael Stapelberg wrote:
> We introduced unpacking tarballs in https://github.com/Debian/dcs/issues/80
> (from 2017!),
> but apparently didn’t think it through far enough regarding sources.d.o :)

Thanks for your answer! And I think we can reasonably assume this edge
case doesn't happen too often. :)

> Would adding support for unpacking tarballs be something you would consider
> in debsources?
> I know that tarballs *technically are the source*, but humans clearly find
> the contents of these tarballs more interesting.

Yes - clearly. The bug to implement tarballs-in-tarballs unpacking has
been open forever, so I think it's quite unlikely it's gonna be picked
up within a reasonable timeframe. I myself won't have time to take
care of this anytime soon.

I can empathize regarding not having enough time, but just want to point out that the change itself ended up being quite simple in terms of lines of code and mental complexity: https://github.com/Debian/dcs/commit/2c94a341f785e2c7552a02500289b95dfe75a83d — as you can see, we just loop over *.tar.* and call “tar xf”.

I’m not saying this to push you to implement it, just mentioning this for your information should you eventually get around to it :)
 

> Otherwise, we could handle these with our own /show handler by checking if
> the source is present in debsources first,
> but that obviously involves one additional request per /show handler, so
> it’s not exactly cheap.

That'd work indeed. Doing nothing also sounds like a reasonable
strategy, given the (assumed) low rate of this failure and the efforts
involved to implement a work-around.

But I'm glad we know where that comes from. Thanks for your thoughts!

Cheers,
--
Matthieu


--
Best regards,
Michael

Reply to: