[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#897377: marked as done (qa.debian.org: Please add '_' in npmjs_project_char_re (fakeupstream.cgi))

Your message dated Tue, 01 May 2018 21:42:50 +0000
with message-id <5ae8df5ad7e3c_21532aaaf07e90d0399d1@godard.mail>
and subject line Bug #897377 in qa.debian.org fixed
has caused the Debian Bug report #897377,
regarding qa.debian.org: Please add '_' in npmjs_project_char_re (fakeupstream.cgi)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
897377: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897377
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qa.debian.org
Severity: normal
Tags: patch

Hi all,

npmjs.com authorizes project to have a '_' in their name. For example
require-optional and require_optional are 2 different projects. Sadly a
lot af npmjs projects don't have valid git tags in their GitHub
repository. That's why fakeupstream.cgi is very useful.

So could you authorize '_' for npmjs.org?

Best regards,
Xavier

--- 8< ---
--- fakeupstream.cgi.orig       2018-05-01 19:20:32.099036786 +0200
+++ fakeupstream.cgi    2018-05-01 19:13:07.621394749 +0200
@@ -47,7 +47,7 @@

 our $project_char_re = '[a-zA-Z0-9\-]';
 our $pypi_project_char_re = '[a-zA-Z0-9\-\.]';
-our $npmjs_project_char_re = '[a-zA-Z0-9\-\.]';
+our $npmjs_project_char_re = '[a-zA-Z0-9\-\._]';
 our $cratesio_project_char_re = '[a-zA-Z0-9_.-]';
 our $github_project_char_re = '[-_.a-zA-Z0-9]';
 our $hg_repository_re = '[a-zA-Z0-9\.\-:/]+';
--- >8 ---

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- End Message ---
--- Begin Message --- 
Hello,

Bug #897377 in qa.debian.org reported by you has been fixed in the Git repository.
You can see the commit message below, and you can check the diff of the fix at:

https://salsa.debian.org/qa/qa/commit/fbf7456e5fff1fe527aca6852dc8e46acc560f25

------------------------------------------------------------------------
fakeupstream: allow '_' in npmjs project names

Closes: #897377
Thanks: Xavier Guimard <x.guimard@free.fr> for the patch
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/897377

--- End Message ---
Reply to: