Bug#915238: bls: Please scan for deprecated LD_LIBRARY_PATH usage during build

[Guillem Jover <guillem@debian.org>]

Package: qa.debian.org
Severity: wishlist
User: qa.debian.org@packages.debian.org
Usertags: bls
Control: clone -1 -2
Control: reassign -2 bls-standalone

Hi!

dpkg-shlibdeps used to recommend using LD_LIBRARY_PATH to set the
path for built libraries to be scanned, before the -l option got
introduced.

Abusing the LD_LIBRARY_PATH environment variable for build paths is
problematic, because that's a run-time variable, so it might end up
affecting things that are executed (for both native and cross builds).
Any such use is wrong and should be switched to use the new -l option,
present since dpkg 1.17.0.

It would be nice if bls detected and emitted an error for this, which
can be scanned from the following dpkg-shlibdeps warning emitted in
the C locale:

  'deprecated use of LD_LIBRARY_PATH with private ' .
  'library directory which interferes with ' .
  'cross-building, please use -l option instead'

It would give a nice overview of how bad the problem is currently, and
when it might bre appropriate to turn that dpkg-shlibdeps warning into
an error in the future. Because this usage is tricky to detect except
at run-time.

Thanks,
Guillem