[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#853189: tracker.debian.org: Ecnoding issue / Code injection through Maintainer field (and probably others)



Hi,

Thanks for submitting a patch, and for your contribution to this bug.

Your patch works proprely on the debian's yaml file, but it appears that you
didn't run the tests after designing it.

Some general recommendations:

 * map(function, iterable) is mostly obsolete, use [function(e) for e in
   iterable] instead, especially in django applications as python3 version
   of map returns an iterator that django is unable to serialize.
 * Your test yaml files were having two issues:
   + No entry in the 'excuses' entry.
   + 'policy-info' should have been 'policy_info'
 * You didn't update expected_data properly in the tests (with yaml,
   integers are casted as integers, and thus in the test file, '20' and '10'
   should have been replaced with 20 and 10)
 * set_update_excuses_content is supposed to call yaml.load() after your
   changes. It didn't.

Thanks for your contribution. :)

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.

Attachment: signature.asc
Description: PGP signature


Reply to: