Bug#882737: qa.debian.org: DDPO links to stable-new diffs are wrong (and wrongly placed)

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

Package: qa.debian.org
User: qa.debian.org@packages.debian.org
Usertags: ddpo
Control: affects -1 + release.debian.org
X-Debbugs-CC: release.debian.org@packages.debian.org

Hi,

When a package is in the (old)stable-new waiting for review and
acceptance / rejection by the Release Team, this is noted in DDPO and a
link to the diff included.

Unfortunately, the links are broken, as they point to ftp-master's NEW
queue, rather than the diffs generated by the SRM tools. They're also
included in the testing and unstable columns, whereas placing them in
the (old)stable column would seem more logical.

As an example, carnil's DDPO page contains (at the time of writing) a
pending upload for liblog-log4perl-perl. The "stable" column contains
"1.48-1" and the "testing / unstable" column "1.49-1 \n stable-new:
1.48-1+deb9u1". The latter is linked to https://ftp-master.debian.org/n
ew/liblog-log4perl-perl_1.48-1%2Bdeb9u1.html , which does not exist.
The correct URL is https://release.debian.org/proposed-updates/stable_d
iffs/liblog-log4perl-perl_1.48-1+deb9u1.debdiff (if it's more
appropriate for DDPO, one can s/stable/stretch/ in the URL as well).

I'm hoping this is relatively simple to change, but please let us know
if there are any queries.

Regards,

Adam