[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#851296: marked as done (tracker.debian.org: broken links for packages containing "+" symbol)

Your message dated Wed, 1 Nov 2017 12:35:43 +0100
with message-id <20171101113543.vqaoja6pi3rj7cta@home.ouaza.com>
and subject line Re: Bug#851296:
has caused the Debian Bug report #851296,
regarding tracker.debian.org: broken links for packages containing "+" symbol
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
851296: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851296
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: tracker.debian.org
Severity: normal

A package with a + in its name, like
<https://tracker.debian.org/pkg/libgetopt++>, has a broken link for
popcon:
<https://qa.debian.org/popcon.php?package=libgetopt++> doesn't work,
because + is interpreted as space in the query string. The correct link
would be <https://qa.debian.org/popcon.php?package=libgetopt%2B%2B>.

Other broken links seen for the same reason:

/accounts/logout/?next=/pkg/libgetopt++ (when logged-in)
https://qa.debian.org/madison.php?package=libgetopt++

Package names in query-strings should be escaped with urllib.quote_plus()
instead of urllib.quote(). The "buildd logs" link seems to do this
correctly, and so do the BTS links.

(It would also be OK to use quote_plus in many other contexts, although
it might be necessary to use quote_plus(..., safe='/') if the string
being substituted includes a directory name.)

--- End Message ---
--- Begin Message --- 
Hi,

On Mon, 30 Oct 2017, Ville Skyttä wrote:
> This set of patches should fix the mentioned issues and more of the
> kind I could find with some grepping.

Thanks, applied your patches. And pushed one more for the madison URL
that was reported as broken too and that you missed.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

--- End Message ---
Reply to: