[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#841984: tracker.debian.org: comment appears on tracker pages



Package: tracker.debian.org
Severity: important
Tags: patch

Hi,

Michael Biebl noticed this message appears on pages like [1]:
|    {# A hidden modal which would display a list of email addresses, allowing the user to choose which one to subscribe to the package. #} 

 1. https://tracker.debian.org/pkg/dpkg

Looking at the git history, it seems a comment going multiline triggered
this. Proposal to fix that attached.


KiBi.
>From 6d37120adefe7eb22f585db6e12dc612c0c94f51 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <kibi@debian.org>
Date: Tue, 25 Oct 2016 01:59:53 +0200
Subject: [PATCH] Fix multiline comment.

This fixes a regression introduced in:
| commit 3f029d09d27ba2fb656c34fa63d5d13edcb1caf1
| Author: Ben Finney <ben.finney@wspdigital.com>
| Date:   Tue Oct 11 16:23:29 2016 +1100
|
|     Rephrase all gendered references to the user, to be gender-neutral.

since the {# foo #} syntax is only for single line comments.
---
 distro_tracker/core/templates/core/package.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/distro_tracker/core/templates/core/package.html b/distro_tracker/core/templates/core/package.html
index d861f27..fadedab 100644
--- a/distro_tracker/core/templates/core/package.html
+++ b/distro_tracker/core/templates/core/package.html
@@ -67,10 +67,10 @@
 {% endblock %}
 
 {% block page-content %}
-{#
+{% comment %}
   A hidden modal which would display a list of email addresses,
   allowing the user to choose which one to subscribe to the package.
-#}
+{% endcomment %}
 {% spaceless %}
 <div id="choose-email-modal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true">
   <div class="modal-dialog" role="document">
-- 
2.1.4


Reply to: