[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#810226: marked as done (tracker.debian.org: buggy_dependency link has an additional /pkg in URL)

Your message dated Fri, 8 Jan 2016 12:11:48 +0100
with message-id <20160108111148.GD29263@home.ouaza.com>
and subject line Re: Bug#810226: tracker.debian.org: buggy_dependency link has an additional /pkg in URL
has caused the Debian Bug report #810226,
regarding tracker.debian.org: buggy_dependency link has an additional /pkg in URL
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
810226: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810226
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Package: tracker.debian.org
Severity: normal
tag

Dear Maintainer,

Whenever a package is marked for autoremoval, the tracker has a message
generated as the following (from
'distro_tracker/vendor/debian/templates/debian/autoremoval-action-item.h
tml'
in
repo)

```
    <span>Version {{ item.extra_data.version }} of {{
item.package.name }} is marked for autoremoval from testing on {{
item.extra_data.removal_date }}. </span>

    {% if bugs %}
    <span>It is affected by {{ bugs|safe }}. </span>
    {% endif %}

    {% if bugs_dependencies %}
    <span>It depends (transitively) on {{ buggy_dependencies|safe }},
affected by {{ bugs_dependencies|safe }}. </span>
    {% endif %}

    </span>You should try to prevent the removal by fixing these RC
bugs.</span>

```

However, the link to the buggy_dependecies
(generated by {{ buggy_dependencies|safe }}) has an additional '/pkg/'
in the
URL, which makes the redirection incorrect.

I believe the attached patch fixes the issue. But, since I am not
familiar with
the codebase and this patch is created from a very quick glance over
the code,
it may be incorrect. But, the fix is quite easy as per my understaning.


- -- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 4.2.0-1-686-pae (SMP w/4 CPU cores)
Locale: LANG=ml_IN, LC_CTYPE=ml_IN (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

- -- 
Regards
Balasankar C
http://balasankarc.in
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCgAGBQJWjm0QAAoJEJbtq5sua3Fx4MkH/2YTycxUYggmDrei5OHtKzhw
S0b6YicmQm8tbF6CEeO5+DE6v/vOqzCP8/vRX4nqqlgpfdYT+ClOh/JXddAZqi3A
CzZDeZCVXLapfr+eEG1QflHu/3Iq8wpughcaMGAMuDIzoPhPqSpWQ0DOUHpx8Djr
dern7N01+skOvQ73y537jBdiudCPz5eMUQBs0jaBqEbMyGtCaUv5kJYDHUhNTZ38
h05AQe1ude2VcVwTkIyC5atEmKxTAMfKem7DFcDBAKO4J2DsfXqjMNhjJoiVIGuB
JDnm61QT8gKIdzBTmTBwJC11j1pJHind8I/1nD2JABCjj4FNdH5H2q0X2N7ERDY=
=jSpi
-----END PGP SIGNATURE-----

diff --git a/distro_tracker/vendor/debian/tracker_tasks.py b/distro_tracker/vendor/debian/tracker_tasks.py
index e45623d..eaabe4f 100644
--- a/distro_tracker/vendor/debian/tracker_tasks.py
+++ b/distro_tracker/vendor/debian/tracker_tasks.py
@@ -2374,7 +2374,7 @@ class UpdateAutoRemovalsStatsTask(BaseTask):
             'bugs_dependencies': ', '.join(
                 link.format(bug, bug) for bug in bugs_dependencies),
             'buggy_dependencies': ' and '.join(
-                ['<a href="/pkg/{}">{}</a>'.format(
+                ['<a href="{}">{}</a>'.format(
                     reverse(
                         'dtracker-package-page',
                         kwargs={'package_name': p}),

Attachment: 0x2E6B7171.asc
Description: application/pgp-keys


--- End Message ---
--- Begin Message --- 
Hello,

On Thu, 07 Jan 2016, Balasankar C wrote:
> However, the link to the buggy_dependecies
> (generated by {{ buggy_dependencies|safe }}) has an additional '/pkg/'
> in the
> URL, which makes the redirection incorrect.
> 
> I believe the attached patch fixes the issue. But, since I am not
> familiar with the codebase and this patch is created from a very quick
> glance over the code, it may be incorrect. But, the fix is quite easy as
> per my understaning.

It looks good, applied to git locally and will deploy it later. Thanks for
your contribution.

Do you feel like helping a bit more with tracker.debian.org? We have a
couple of bugs for newcomers:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=tracker.debian.org;tag=newcomer

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

--- End Message ---
Reply to: